RESOLVED FIXED 210594
Validate socket in NetworkRTCProvider::wrapNewTCPConnection 
https://bugs.webkit.org/show_bug.cgi?id=210594
Summary Validate socket in NetworkRTCProvider::wrapNewTCPConnection
youenn fablet
Reported 2020-04-16 01:02:34 PDT
Validate socket in NetworkRTCProvider::wrapNewTCPConnection
Attachments
Patch (1.95 KB, patch)
2020-04-16 01:04 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.07 KB, patch)
2020-04-17 05:38 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-04-16 01:03:03 PDT
rdar://problem/61783652
youenn fablet
Comment 2 2020-04-16 01:04:58 PDT
Created attachment 396627 [details] Patch
Eric Carlson
Comment 3 2020-04-16 06:59:58 PDT
Comment on attachment 396627 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396627&action=review > Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp:176 > + if (auto socket = m_pendingIncomingSockets.take(newConnectionSocketIdentifier)) > + addSocket(identifier, makeUnique<LibWebRTCSocketClient>(identifier, *this, WTFMove(socket), Socket::Type::ServerConnectionTCP)); Would logging when the socket is NULL be helpful?
youenn fablet
Comment 4 2020-04-17 05:38:45 PDT
Created attachment 396757 [details] Patch for landing
EWS
Comment 5 2020-04-17 10:18:04 PDT
Committed r260260: <https://trac.webkit.org/changeset/260260> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396757 [details].
Note You need to log in before you can comment on or make changes to this bug.