Bug 210574 - Disable Store-load pair auto-vectorization for JSC
Summary: Disable Store-load pair auto-vectorization for JSC
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
Keywords: InRadar
Depends on:
Reported: 2020-04-15 15:21 PDT by Keith Miller
Modified: 2020-04-15 18:46 PDT (History)
11 users (show)

See Also:

Patch (2.98 KB, patch)
2020-04-15 15:35 PDT, Keith Miller
ggaren: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2020-04-15 15:21:02 PDT
Disable Store-load pair auto-vectorization for JSC
Comment 1 Keith Miller 2020-04-15 15:35:47 PDT
Created attachment 396581 [details]
Comment 2 Geoffrey Garen 2020-04-15 15:45:00 PDT
Comment on attachment 396581 [details]


Seems like this is worth a bug report for clang/llvm.
Comment 3 EWS 2020-04-15 17:20:06 PDT
Found 4 new test failures: imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/style-change-events.html, imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate.html, imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/target.html, imported/w3c/web-platform-tests/web-animations/interfaces/Animation/commitStyles.html
Comment 4 Keith Miller 2020-04-15 17:21:39 PDT
(In reply to EWS from comment #3)
> Found 4 new test failures:
> imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/
> style-change-events.html,
> imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate.
> html,
> imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/
> target.html,
> imported/w3c/web-platform-tests/web-animations/interfaces/Animation/
> commitStyles.html

Huh, how did these fail on CQ but not on EWS? They also don't fail locally...
Comment 5 Keith Miller 2020-04-15 18:45:26 PDT
Committed r260166: <https://trac.webkit.org/changeset/260166>
Comment 6 Radar WebKit Bug Importer 2020-04-15 18:46:13 PDT