RESOLVED FIXED 210566
Switch NetworkProcess and NetworkProcessProxy messages to use CallbackID class 
https://bugs.webkit.org/show_bug.cgi?id=210566
Summary Switch NetworkProcess and NetworkProcessProxy messages to use CallbackID class
Brent Fulgham
Reported 2020-04-15 13:22:42 PDT
Instead of using the raw uint64_t type to represent callbacks, use the purpose built WebKit::CallbackID type.
Attachments
Patch (15.81 KB, patch)
2020-04-15 13:29 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch for landing (16.11 KB, patch)
2020-04-16 17:27 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2020-04-15 13:24:11 PDT
<rdar://problem/61791784>
Brent Fulgham
Comment 2 2020-04-15 13:29:46 PDT
Created attachment 396567 [details] Patch
David Kilzer (:ddkilzer)
Comment 3 2020-04-15 17:16:36 PDT
Comment on attachment 396567 [details] Patch r=me (mac-wk2 is orange, so I didn't mark cq+)
Brent Fulgham
Comment 4 2020-04-16 12:08:09 PDT
It looks like Mac-wk2 is in some horrible state. Every patch I look at claims it is broken.
Brent Fulgham
Comment 5 2020-04-16 17:26:16 PDT
I confirmed that the test results are the same with or without the patch locally.
Brent Fulgham
Comment 6 2020-04-16 17:27:44 PDT
Created attachment 396727 [details] Patch for landing
EWS
Comment 7 2020-04-16 17:53:12 PDT
Committed r260231: <https://trac.webkit.org/changeset/260231> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396727 [details].
Note You need to log in before you can comment on or make changes to this bug.