Bug 210560 - Add a test to ensure WebKit::mayContainEditableElementsInRect() returns true if the document element is editable
Summary: Add a test to ensure WebKit::mayContainEditableElementsInRect() returns true ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-15 11:36 PDT by Daniel Bates
Modified: 2020-04-18 16:18 PDT (History)
2 users (show)

See Also:

Attachments
Add a layout test (2.71 KB, patch)
2020-04-15 11:39 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
To Land (2.62 KB, patch)
2020-04-18 16:17 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2020-04-15 11:36:01 PDT 
Add a test to ensure WebKit::mayContainEditableElementsInRect() returns true if <html contenteditable="true">.
Comment 1 Daniel Bates 2020-04-15 11:39:05 PDT 
Created attachment 396554 [details]
Add a layout test
Comment 2 Daniel Bates 2020-04-18 09:22:32 PDT 
EWS failures are clearly unrelated.
Comment 3 Simon Fraser (smfr) 2020-04-18 16:11:53 PDT 
Comment on attachment 396554 [details]
Add a layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=396554&action=review

> LayoutTests/editing/editable-region/hit-test-editable-document-element.html:13
> +if (window.testRunner)
> +    testRunner.dumpAsText();

You don't need this with a js test.
Comment 4 Daniel Bates 2020-04-18 16:13:13 PDT 
Comment on attachment 396554 [details]
Add a layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=396554&action=review

Thanks Simon for the review!

>> LayoutTests/editing/editable-region/hit-test-editable-document-element.html:13
>> +    testRunner.dumpAsText();
> 
> You don't need this with a js test.

yep, will remove
Comment 5 Daniel Bates 2020-04-18 16:17:12 PDT 
Created attachment 396870 [details]
To Land
Comment 6 Daniel Bates 2020-04-18 16:17:35 PDT 
Committed r260326: <https://trac.webkit.org/changeset/260326>
Comment 7 Radar WebKit Bug Importer 2020-04-18 16:18:14 PDT 
<rdar://problem/61987019>