Bug 210558 - REGRESSION (r259762): Should always hit test for editable elements if the WKWebView is fully editable
Summary: REGRESSION (r259762): Should always hit test for editable elements if the WKW...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad iOS 13
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on: 210398
Blocks:
  Show dependency treegraph
 
Reported: 2020-04-15 11:09 PDT by Daniel Bates
Modified: 2020-04-16 09:52 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.73 KB, patch)
2020-04-15 11:34 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff
To Land (3.65 KB, patch)
2020-04-15 11:45 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2020-04-15 11:09:32 PDT
If the WKWebView is fully editable (-[WKWebView _setEditable:YES] was called on it) then always hit test for editable elements.
Comment 1 Daniel Bates 2020-04-15 11:09:44 PDT
<rdar://problem/61798347>
Comment 2 Daniel Bates 2020-04-15 11:34:04 PDT
Created attachment 396553 [details]
Patch
Comment 3 Wenson Hsieh 2020-04-15 11:35:54 PDT
Comment on attachment 396553 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396553&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:205
> +    NSArray<_WKTextInputContext *> *contexts;

Nit - maybe just move this down so that it’s `NSArray<_WKTextInputContext *> *contexts = [webView synchronouslyRequestTextInputContextsInRect:[webView bounds]];`?
Comment 4 Daniel Bates 2020-04-15 11:43:59 PDT
Comment on attachment 396553 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396553&action=review

Thanks for the review!

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:205
>> +    NSArray<_WKTextInputContext *> *contexts;
> 
> Nit - maybe just move this down so that it’s `NSArray<_WKTextInputContext *> *contexts = [webView synchronouslyRequestTextInputContextsInRect:[webView bounds]];`?

I'll just inline [webView synchronouslyRequestTextInputContextsInRect:[webView bounds]] into the EXPECT_GE to get rid of the local altogether.
Comment 5 Daniel Bates 2020-04-15 11:45:39 PDT
Created attachment 396556 [details]
To Land
Comment 6 Daniel Bates 2020-04-16 09:52:29 PDT
Comment on attachment 396556 [details]
To Land

Clearing flags on attachment: 396556

Committed r260193: <https://trac.webkit.org/changeset/260193>
Comment 7 Daniel Bates 2020-04-16 09:52:31 PDT
All reviewed patches have been landed.  Closing bug.