Add gtk_init and gtk_init_check receiving parameters to GtkVersioning
Created attachment 396539 [details] Patch Patch doesn't include the plugin process main (because we should disable plugin process in gtk4) and MiniBrowser that should probably use GtkApplication instead.
Committed r260132: <https://trac.webkit.org/changeset/260132>
Why was this landed with red EWS? A clean build fails here, same as in the EWS: ../../../Tools/TestWebKitAPI/gtk/main.cpp:29:10: fatal error: 'WebCore/GtkVersioning.h' file not found #include <WebCore/GtkVersioning.h> ^~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. $ find WebKitBuild/GTK/ -name GtkVersioning.h $
(In reply to Philippe Normand from comment #3) > Why was this landed with red EWS? Because I fixed the build error before landing, at least locally. > A clean build fails here, same as in the EWS: > > > ../../../Tools/TestWebKitAPI/gtk/main.cpp:29:10: fatal error: > 'WebCore/GtkVersioning.h' file not found > #include <WebCore/GtkVersioning.h> > ^~~~~~~~~~~~~~~~~~~~~~~~~ > 1 error generated. > > $ find WebKitBuild/GTK/ -name GtkVersioning.h > $ That's different error, we should probably make WebCore a dependency of TestWebKitAPI to ensure the forwarding header is generated before.