Bug 21055 - not invoked functions
Summary: not invoked functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Trivial
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-24 05:14 PDT by Gabriella Toth
Modified: 2008-11-10 02:05 PST (History)
0 users

See Also:


Attachments
proposed patch (14.76 KB, patch)
2008-09-24 05:15 PDT, Gabriella Toth
eric: review-
Details | Formatted Diff | Diff
proposed patch (2.53 KB, patch)
2008-09-25 01:49 PDT, Gabriella Toth
timothy: review-
Details | Formatted Diff | Diff
proposed patch (3.38 KB, patch)
2008-09-25 01:49 PDT, Gabriella Toth
no flags Details | Formatted Diff | Diff
proposed patch (3.94 KB, patch)
2008-09-25 01:50 PDT, Gabriella Toth
timothy: review-
Details | Formatted Diff | Diff
proposed patch (1.39 KB, patch)
2008-09-25 02:22 PDT, Gabriella Toth
no flags Details | Formatted Diff | Diff
proposed patch (1.88 KB, patch)
2008-09-25 02:47 PDT, Gabriella Toth
timothy: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriella Toth 2008-09-24 05:14:14 PDT
I performed static source code analysis on WebKit and found 6 functions which are not invoked at all, therefore they can be deleted.

The list of functions:
    * start_iter (JavaScriptCore/wtf/AVLTree.h,  line: 168, Lines of Code (LOC) = 49)
    * setStandardAttributes (WebCore/svg/SVGFilterPrimitiveStandardAttributes.cpp, line: 72, LOC = 53)
    * scrollTo (WebCore/page/FrameView.cpp, line 565, LOC = 64)
    * canReplaceChild (WebCore/dom/Document.cpp, line 2002, LOC = 84)
    * statementListInitializeVariableAccessStack (JavaScriptCore/kjs/nodes.cpp, line 1103, LOC = 16)
    * callOnMainThreadAndWait (JavaScriptCore/wtf/MainThread.cpp, line 106, LOC = 21)
Comment 1 Gabriella Toth 2008-09-24 05:15:27 PDT
Created attachment 23748 [details]
proposed patch
Comment 2 Eric Seidel (no email) 2008-09-24 15:20:22 PDT
Comment on attachment 23748 [details]
proposed patch

Some of these should probably have ifdefs around them (like USE(SVG_FILTERS), but I don't think all of these should be deleted.  We should address these each with separate patches.
Comment 3 Gabriella Toth 2008-09-25 01:49:14 PDT
Created attachment 23785 [details]
proposed patch
Comment 4 Gabriella Toth 2008-09-25 01:49:57 PDT
Created attachment 23786 [details]
proposed patch
Comment 5 Gabriella Toth 2008-09-25 01:50:32 PDT
Created attachment 23787 [details]
proposed patch
Comment 6 Gabriella Toth 2008-09-25 02:22:35 PDT
Created attachment 23788 [details]
proposed patch
Comment 7 Gabriella Toth 2008-09-25 02:47:32 PDT
Created attachment 23789 [details]
proposed patch
Comment 8 Timothy Hatcher 2008-09-25 07:30:32 PDT
Comment on attachment 23789 [details]
proposed patch

The callOnMainThreadAndWait function was added only 3 weeks ago and it the ground work for future tasks that will use it. r36056
Comment 9 Timothy Hatcher 2008-09-25 07:36:53 PDT
Comment on attachment 23787 [details]
proposed patch

The Document::canReplaceChild method is replaces the base-class Node::canReplaceChild version.
Comment 10 Darin Adler 2008-09-29 09:12:05 PDT
Comment on attachment 23788 [details]
proposed patch

r=me
Comment 11 Alexey Proskuryakov 2008-09-30 07:48:52 PDT
Comment on attachment 23786 [details]
proposed patch

FrameView::scrollTo() has been recently removed by Hyatt.
Comment 12 Darin Adler 2008-10-12 19:16:11 PDT
Comment on attachment 23788 [details]
proposed patch

Clearing the review flag because this has been landed.
Comment 13 Timothy Hatcher 2008-10-17 04:10:11 PDT
Comment on attachment 23785 [details]
proposed patch

I don't think we should remove AVLTree::start_iter just because it isn't used today.
Comment 14 Gabriella Toth 2008-11-10 02:05:29 PST
Ok. It can be closed.