Bug 210544 – TextureMapper renders video element with "object-fit: cover" incorrectly

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Tomoki Imai]

WebKitGTK with AC mode renders compositing/video/video-object-fit.html incorrectly.
The video layer spill outside of the box when "object-fit:cover" is specified.

We need to propagate GraphicsLayer::contentsClippingRect (see bug 52103) to TextureMapper.

[Tomoki Imai]

Created attachment 396522 [details]
patch

[Tomoki Imai]

Unfortunately compositing/video/video-object-fit.html is disabled due to bug 177536  and bug 163528.
It might be better to re-enabled it again if possible.

[Tomoki Imai]

I tried to enable compositing/video/video-object-fit.html test in GTK, it doesn't crash for several run-webkit-tests.
But instead of crash, I see some text diff failure.
Where does "(anchor 0.00 0.00)" come from?

--- /app/webkit/WebKitBuild/Release/layout-test-results/compositing/video/video-object-fit-expected.txt
+++ /app/webkit/WebKitBuild/Release/layout-test-results/compositing/video/video-object-fit-actual.txt
@@ -1,5 +1,6 @@
-   
+        
 (GraphicsLayer
+  (anchor 0.00 0.00)
   (bounds 785.00 775.00)
   (children 1
     (GraphicsLayer

[Zan Dobersek]

(In reply to Tomoki Imai from comment #3)
> I tried to enable compositing/video/video-object-fit.html test in GTK, it
> doesn't crash for several run-webkit-tests.
> But instead of crash, I see some text diff failure.
> Where does "(anchor 0.00 0.00)" come from?
> 
> ---
> /app/webkit/WebKitBuild/Release/layout-test-results/compositing/video/video-
> object-fit-expected.txt
> +++
> /app/webkit/WebKitBuild/Release/layout-test-results/compositing/video/video-
> object-fit-actual.txt
> @@ -1,5 +1,6 @@
> -   
> +        
>  (GraphicsLayer
> +  (anchor 0.00 0.00)
>    (bounds 785.00 775.00)
>    (children 1
>      (GraphicsLayer

It's just an extra parameter that's reported for the GraphicsLayer state, compared to the current -expected.txt baseline. It's not incorrect, but the -expected.txt file will require rebaselining.

[Zan Dobersek]

Comment on attachment 396522 [details]
patch

Please do the rebaselining of the relevant test in a follow-up patch.

[EWS]

Committed r260174: <https://trac.webkit.org/changeset/260174>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396522 [details].

[Tomoki Imai]

Thanks for your review!
I will try to re-enable compositing/video/video-object-fit.html and re-baselining in bug 177536 or bug 163528