WebKitGTK with AC mode renders compositing/video/video-object-fit.html incorrectly.
The video layer spill outside of the box when "object-fit:cover" is specified.
We need to propagate GraphicsLayer::contentsClippingRect (see bug 52103) to TextureMapper.
Created attachment 396522 [details]
Unfortunately compositing/video/video-object-fit.html is disabled due to bug 177536 and bug 163528.
It might be better to re-enabled it again if possible.
I tried to enable compositing/video/video-object-fit.html test in GTK, it doesn't crash for several run-webkit-tests.
But instead of crash, I see some text diff failure.
Where does "(anchor 0.00 0.00)" come from?
@@ -1,5 +1,6 @@
+ (anchor 0.00 0.00)
(bounds 785.00 775.00)
(In reply to Tomoki Imai from comment #3)
> I tried to enable compositing/video/video-object-fit.html test in GTK, it
> doesn't crash for several run-webkit-tests.
> But instead of crash, I see some text diff failure.
> Where does "(anchor 0.00 0.00)" come from?
> @@ -1,5 +1,6 @@
> + (anchor 0.00 0.00)
> (bounds 785.00 775.00)
> (children 1
It's just an extra parameter that's reported for the GraphicsLayer state, compared to the current -expected.txt baseline. It's not incorrect, but the -expected.txt file will require rebaselining.
Comment on attachment 396522 [details]
Please do the rebaselining of the relevant test in a follow-up patch.
Committed r260174: <https://trac.webkit.org/changeset/260174>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 396522 [details].
Thanks for your review!
I will try to re-enable compositing/video/video-object-fit.html and re-baselining in bug 177536 or bug 163528