Bug 210532 - isNullFunctionPointer() can fail for symbols not explicitly marked as weakly linked.
Summary: isNullFunctionPointer() can fail for symbols not explicitly marked as weakly ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-14 22:03 PDT by Jer Noble
Modified: 2020-04-15 09:09 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.70 KB, patch)
2020-04-14 22:11 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2020-04-14 22:03:52 PDT 
isNullFunctionPointer() can fail for symbols not explicitly marked as weakly linked.
Comment 1 Jer Noble 2020-04-14 22:11:47 PDT 
Created attachment 396499 [details]
Patch
Comment 2 EWS 2020-04-15 08:32:25 PDT 
Committed r260129: <https://trac.webkit.org/changeset/260129>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396499 [details].
Comment 3 Radar WebKit Bug Importer 2020-04-15 08:33:14 PDT 
<rdar://problem/61829150>
Comment 4 Sam Weinig 2020-04-15 08:45:19 PDT 
I don't think this is the right approach for this. If we are going to change libWebRTC, I think we should add a non-function symbol to use to check weak-linkage.  And we should remove isNullFunctionPointer() or fix it it, but not leave it half working (see https://bugs.webkit.org/show_bug.cgi?id=208873)