Bug 210531 – Data Detected Actions sheets are presented from odd locations.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Data Detected Actions sheets are presented from odd locations.

[Megan Gardner]

Created attachment 396498 [details]
Patch

[Tim Horton]

Comment on attachment 396498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396498&action=review

> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:757
> +    if ([delegate respondsToSelector:@selector(_createTargetedContextMenuHintPreviewIfPossible)])
> +        return [delegate _createTargetedContextMenuHintPreviewIfPossible];

Is this not important for other clients of WKActionSheetAssistant (whoever they are? WKPDFView?)

[Wenson Hsieh]

Comment on attachment 396498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396498&action=review

> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.h:66
> +- (UITargetedPreview *)_createTargetedContextMenuHintPreviewIfPossible;

Nit - delegate methods usually take the object that’s calling into the delegate as an argument.

[Tim Horton]

Comment on attachment 396498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396498&action=review

> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.h:66
> +- (UITargetedPreview *)_createTargetedContextMenuHintPreviewIfPossible;

where's the parameter indicating which action sheet assistant the delegate should respond for?

[Megan Gardner]

Created attachment 396543 [details]
Patch

[Wenson Hsieh]

Comment on attachment 396543 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396543&action=review

> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:757
> +    if ([delegate respondsToSelector:@selector(createTargetedContextMenuHintForAcitionSheetAssistant:)])
> +        return [delegate createTargetedContextMenuHintForAcitionSheetAssistant:self];

Nit - “Acition"

[Megan Gardner]

Created attachment 396552 [details]
Patch for landing

[EWS]

Found 4 new test failures: imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/style-change-events.html, imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate.html, imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/target.html, imported/w3c/web-platform-tests/web-animations/interfaces/Animation/commitStyles.html

[Megan Gardner]

Committed r260146: <https://trac.webkit.org/changeset/260146>

[Radar WebKit Bug Importer]

<rdar://problem/61844617>