Bug 210529 – Video elements don't return to the correct position when exiting fullscreen

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Peng Liu]

Video elements don't return to the correct position when exiting fullscreen

[Peng Liu]

<rdar://problem/58845689>

[Peng Liu]

Created attachment 396491 [details]
Patch

[Jer Noble]

Comment on attachment 396491 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396491&action=review

> Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:780
>              page->setSuppressVisibilityUpdates(false);
> +            page->setNeedsDOMWindowResizeEvent();

Aha! I bet the previous call to `setSuppressVisibilityUpdate(true)` has the unintended side effect of suppressing the "resize" event too! This seems like a fine fix.

[Simon Fraser (smfr)]

Comment on attachment 396491 [details]
Patch

Can we make a layout test?

[Jer Noble]

(In reply to Simon Fraser (smfr) from comment #4)
> Comment on attachment 396491 [details]
> Patch
> 
> Can we make a layout test?

Layout tests never hit this path, because layout tests (purposefully) don't actually hit the NSWindow layer.

[Simon Fraser (smfr)]

API test then?

[Peng Liu]

This bug is tricky to reproduce with a simple test page. Actually it only happens on some specific website. Filed bug 210568 for it.

[EWS]

Committed r260150: <https://trac.webkit.org/changeset/260150>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396491 [details].