WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
210521
Move ApplePay code from WebKitAdditions to WebCore and WebKit
https://bugs.webkit.org/show_bug.cgi?id=210521
Summary
Move ApplePay code from WebKitAdditions to WebCore and WebKit
Alex Christensen
Reported
2020-04-14 16:11:43 PDT
Move ApplePay code from WebKitAdditions to WebCore and WebKit
Attachments
Patch
(121.56 KB, patch)
2020-04-14 16:20 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(121.62 KB, patch)
2020-04-14 16:40 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(121.52 KB, patch)
2020-04-14 16:47 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(121.55 KB, patch)
2020-04-14 17:03 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(122.27 KB, patch)
2020-04-14 17:21 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(122.51 KB, patch)
2020-04-14 17:42 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(122.42 KB, patch)
2020-04-14 18:30 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(122.51 KB, patch)
2020-04-14 19:08 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(123.02 KB, patch)
2020-04-14 20:56 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(123.23 KB, patch)
2020-04-14 21:42 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(123.80 KB, patch)
2020-04-14 23:22 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(128.48 KB, patch)
2020-04-25 15:42 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Show Obsolete
(11)
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2020-04-14 16:20:45 PDT
Created
attachment 396473
[details]
Patch
Alex Christensen
Comment 2
2020-04-14 16:40:54 PDT
Created
attachment 396475
[details]
Patch
Alex Christensen
Comment 3
2020-04-14 16:47:03 PDT
Created
attachment 396477
[details]
Patch
Alex Christensen
Comment 4
2020-04-14 17:03:52 PDT
Created
attachment 396479
[details]
Patch
Alex Christensen
Comment 5
2020-04-14 17:21:13 PDT
Created
attachment 396480
[details]
Patch
Alex Christensen
Comment 6
2020-04-14 17:42:05 PDT
Created
attachment 396483
[details]
Patch
Alex Christensen
Comment 7
2020-04-14 18:30:13 PDT
Created
attachment 396487
[details]
Patch
Alex Christensen
Comment 8
2020-04-14 19:08:14 PDT
Created
attachment 396489
[details]
Patch
Alex Christensen
Comment 9
2020-04-14 20:56:36 PDT
Created
attachment 396495
[details]
Patch
Alex Christensen
Comment 10
2020-04-14 21:42:29 PDT
Created
attachment 396496
[details]
Patch
Alex Christensen
Comment 11
2020-04-14 23:22:40 PDT
Created
attachment 396505
[details]
Patch
Alex Christensen
Comment 12
2020-04-15 10:14:59 PDT
Hooray! I got all EWS green. This needs to be landed at the same time as removing the internal files to not break the internal build, so I'll do this late at night.
Alex Christensen
Comment 13
2020-04-18 21:39:12 PDT
Comment on
attachment 396505
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=396505&action=review
> Source/WebCore/DerivedSources.make:-1258 > --include WebCoreDerivedSourcesAdditions.make
This is still needed. I won't remove it.
Alex Christensen
Comment 14
2020-04-18 21:57:03 PDT
This is super tricky to do without renaming all the new files because internal SDKs have all the files in them and they are included. I think I'll have to put a prefix on all the new files.
Alex Christensen
Comment 15
2020-04-25 15:42:13 PDT
Created
attachment 397593
[details]
Patch
Alex Christensen
Comment 16
2020-04-25 20:03:49 PDT
http://trac.webkit.org/r260717
Alex Christensen
Comment 17
2020-04-25 20:04:15 PDT
Corresponding internal change ef405149415e6e6f7df4758f25f06befdff410a1
Radar WebKit Bug Importer
Comment 18
2020-04-25 20:04:16 PDT
<
rdar://problem/62379475
>
Alex Christensen
Comment 19
2020-04-25 20:32:50 PDT
https://trac.webkit.org/changeset/260718/webkit
Alex Christensen
Comment 20
2020-04-25 21:11:58 PDT
https://trac.webkit.org/changeset/260719/webkit
Alex Christensen
Comment 21
2020-04-25 21:58:21 PDT
https://trac.webkit.org/r260721
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug