Bug 210521 - Move ApplePay code from WebKitAdditions to WebCore and WebKit
Summary: Move ApplePay code from WebKitAdditions to WebCore and WebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-14 16:11 PDT by Alex Christensen
Modified: 2020-04-25 21:58 PDT (History)
11 users (show)

See Also:


Attachments
Patch (121.56 KB, patch)
2020-04-14 16:20 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (121.62 KB, patch)
2020-04-14 16:40 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (121.52 KB, patch)
2020-04-14 16:47 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (121.55 KB, patch)
2020-04-14 17:03 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (122.27 KB, patch)
2020-04-14 17:21 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (122.51 KB, patch)
2020-04-14 17:42 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (122.42 KB, patch)
2020-04-14 18:30 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (122.51 KB, patch)
2020-04-14 19:08 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (123.02 KB, patch)
2020-04-14 20:56 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (123.23 KB, patch)
2020-04-14 21:42 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (123.80 KB, patch)
2020-04-14 23:22 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (128.48 KB, patch)
2020-04-25 15:42 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-04-14 16:11:43 PDT
Move ApplePay code from WebKitAdditions to WebCore and WebKit
Comment 1 Alex Christensen 2020-04-14 16:20:45 PDT
Created attachment 396473 [details]
Patch
Comment 2 Alex Christensen 2020-04-14 16:40:54 PDT
Created attachment 396475 [details]
Patch
Comment 3 Alex Christensen 2020-04-14 16:47:03 PDT
Created attachment 396477 [details]
Patch
Comment 4 Alex Christensen 2020-04-14 17:03:52 PDT
Created attachment 396479 [details]
Patch
Comment 5 Alex Christensen 2020-04-14 17:21:13 PDT
Created attachment 396480 [details]
Patch
Comment 6 Alex Christensen 2020-04-14 17:42:05 PDT
Created attachment 396483 [details]
Patch
Comment 7 Alex Christensen 2020-04-14 18:30:13 PDT
Created attachment 396487 [details]
Patch
Comment 8 Alex Christensen 2020-04-14 19:08:14 PDT
Created attachment 396489 [details]
Patch
Comment 9 Alex Christensen 2020-04-14 20:56:36 PDT
Created attachment 396495 [details]
Patch
Comment 10 Alex Christensen 2020-04-14 21:42:29 PDT
Created attachment 396496 [details]
Patch
Comment 11 Alex Christensen 2020-04-14 23:22:40 PDT
Created attachment 396505 [details]
Patch
Comment 12 Alex Christensen 2020-04-15 10:14:59 PDT
Hooray!  I got all EWS green.
This needs to be landed at the same time as removing the internal files to not break the internal build, so I'll do this late at night.
Comment 13 Alex Christensen 2020-04-18 21:39:12 PDT
Comment on attachment 396505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396505&action=review

> Source/WebCore/DerivedSources.make:-1258
> --include WebCoreDerivedSourcesAdditions.make

This is still needed.  I won't remove it.
Comment 14 Alex Christensen 2020-04-18 21:57:03 PDT
This is super tricky to do without renaming all the new files because internal SDKs have all the files in them and they are included.  I think I'll have to put a prefix on all the new files.
Comment 15 Alex Christensen 2020-04-25 15:42:13 PDT
Created attachment 397593 [details]
Patch
Comment 16 Alex Christensen 2020-04-25 20:03:49 PDT
http://trac.webkit.org/r260717
Comment 17 Alex Christensen 2020-04-25 20:04:15 PDT
Corresponding internal change ef405149415e6e6f7df4758f25f06befdff410a1
Comment 18 Radar WebKit Bug Importer 2020-04-25 20:04:16 PDT
<rdar://problem/62379475>
Comment 19 Alex Christensen 2020-04-25 20:32:50 PDT
https://trac.webkit.org/changeset/260718/webkit
Comment 20 Alex Christensen 2020-04-25 21:11:58 PDT
https://trac.webkit.org/changeset/260719/webkit
Comment 21 Alex Christensen 2020-04-25 21:58:21 PDT
https://trac.webkit.org/r260721