Bug 210510 - Content expanding is broken on icourse163.org
Summary: Content expanding is broken on icourse163.org
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-14 12:26 PDT by zalan
Modified: 2020-04-14 19:46 PDT (History)
9 users (show)

See Also:


Attachments
Patch (3.88 KB, patch)
2020-04-14 12:30 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (3.79 KB, patch)
2020-04-14 19:21 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-04-14 12:26:33 PDT
1. navigate to https://www.icourse163.org/help/help.htm#/hf?t=2
2. Try to click on any of the drop down arrow buttons and observe the non-animated expanding.
Comment 1 zalan 2020-04-14 12:26:43 PDT
<rdar://problem/45951820>
Comment 2 zalan 2020-04-14 12:30:16 PDT
Created attachment 396449 [details]
Patch
Comment 3 zalan 2020-04-14 12:32:42 PDT
needs quirk test
Comment 4 Simon Fraser (smfr) 2020-04-14 15:23:36 PDT
Comment on attachment 396449 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396449&action=review

> Source/WebCore/page/Quirks.cpp:166
> +    // www.icourse163.org's animation code expects a decimal point in the rAF timestamp (millisecond resolution).

This should reference the radar number, rather than have this comment here I think.
Comment 5 Darin Adler 2020-04-14 15:26:18 PDT
Comment on attachment 396449 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396449&action=review

>> Source/WebCore/page/Quirks.cpp:166
>> +    // www.icourse163.org's animation code expects a decimal point in the rAF timestamp (millisecond resolution).
> 
> This should reference the radar number, rather than have this comment here I think.

You mean WebKit bugs.webkit.org bug number?
Comment 6 Simon Fraser (smfr) 2020-04-14 15:32:13 PDT
(In reply to Darin Adler from comment #5)
> Comment on attachment 396449 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=396449&action=review
> 
> >> Source/WebCore/page/Quirks.cpp:166
> >> +    // www.icourse163.org's animation code expects a decimal point in the rAF timestamp (millisecond resolution).
> > 
> > This should reference the radar number, rather than have this comment here I think.
> 
> You mean WebKit bugs.webkit.org bug number?

If we're fine with the quirk being public, sure. Enough to track it down in future if we need to know if we can remove the quirk.
Comment 7 zalan 2020-04-14 19:21:14 PDT
Created attachment 396490 [details]
Patch
Comment 8 EWS 2020-04-14 19:46:49 PDT
Committed r260114: <https://trac.webkit.org/changeset/260114>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396490 [details].