Bug 210509 – Remove generic parameter serialization fallback

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brent Fulgham]

Improved injected bundle serialization was implemented in Bug 201810. It is time to remove the compatibility fallback so that we can ensure we are always using the modern implementation.

[Brent Fulgham]

Created attachment 396447 [details]
Patch

[Brent Fulgham]

<rdar://problem/55522650>

[Brent Fulgham]

The api-ios test failure looks relevant:

u'TestWebKitAPI.WebKit.WKWebProcessPlugInWithoutRegisteredCustomClass

[Brent Fulgham]

(In reply to Brent Fulgham from comment #3)
> The api-ios test failure looks relevant:
> 
> u'TestWebKitAPI.WebKit.WKWebProcessPlugInWithoutRegisteredCustomClass

Oh! This is behaving correctly, now that we are denying serialization of unregistered classes. The related WKWebProcessPlugInWithRegisteredCustomClass works as expected.

I'll update the test expectation.

[Brent Fulgham]

Created attachment 396471 [details]
Patch

[Geoffrey Garen]

Comment on attachment 396471 [details]
Patch

r=me

How did we determine that clients have stopped using the legacy code path?

[EWS]

Committed r260134: <https://trac.webkit.org/changeset/260134>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396471 [details].

[Brent Fulgham]

(In reply to Geoffrey Garen from comment #6)
> Comment on attachment 396471 [details]
> Patch
> 
> r=me
> 
> How did we determine that clients have stopped using the legacy code path?

In 2017 I reached out to the relevant clients (since injected bundles are SPI) and worked with them to stop using the old code path. Foundation now generates simulated crashes any time NSKeyedUnarchiver uses 'NSObject class' as the root for unarchiving so it was possible to see what wasn't updated yet.