WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
210504
Add bundle SPI to call WebPage::setTopContentInset
https://bugs.webkit.org/show_bug.cgi?id=210504
Summary
Add bundle SPI to call WebPage::setTopContentInset
Alex Christensen
Reported
2020-04-14 11:20:32 PDT
Add bundle SPI to call WebPage::setTopContentInset
Attachments
Patch
(4.28 KB, patch)
2020-04-14 11:21 PDT
,
Alex Christensen
simon.fraser
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2020-04-14 11:21:23 PDT
Created
attachment 396442
[details]
Patch
Radar WebKit Bug Importer
Comment 2
2020-04-14 11:21:50 PDT
<
rdar://problem/61781406
>
Simon Fraser (smfr)
Comment 3
2020-04-14 11:50:14 PDT
Comment on
attachment 396442
[details]
Patch Please explain how this interacts with WebViewImpl::updateContentInsetsIfAutomatic() - m_automaticallyAdjustsContentInsets is on by default in WKWebView. That's called from WebViewImpl::renewGStateI(), which is called whenever AppKit jiggles the view hierarchy, which is a lot.
Alex Christensen
Comment 4
2020-04-14 13:04:14 PDT
When this is called we could also send a message to the WebPageProxy to update it. Would that resolve your concerns?
Tim Horton
Comment 5
2020-04-14 13:07:40 PDT
What does it /mean/, though? Does automaticallyAdjustsContentInsets become NO, too? It's all very weird. But definitely the UIProcess needs to know when it changes, yes.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug