Bug 210500 - Make WTR::AccessibilityUIElements calls to accessibilitySetValue run on AX secondary thread. web content
Summary: Make WTR::AccessibilityUIElements calls to accessibilitySetValue run on AX s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-14 09:00 PDT by Andres Gonzalez
Modified: 2020-04-14 11:49 PDT (History)
9 users (show)

See Also:

Attachments
Patch (17.76 KB, patch)
2020-04-14 09:09 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (18.30 KB, patch)
2020-04-14 11:03 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-04-14 09:00:40 PDT 
Make WTR::AccessibilityUIElements calls to accessibilitySetValue  run on AX secondary thread. web content
Comment 1 Andres Gonzalez 2020-04-14 09:09:48 PDT 
Created attachment 396422 [details]
Patch
Comment 2 chris fleizach 2020-04-14 09:13:59 PDT 
Comment on attachment 396422 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396422&action=review

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:1479
> +    NSArray* selectedChildren = attributeValue(m_element.get(), NSAccessibilitySelectedChildrenAttribute);

objectiveC pointers actually supposed to stay on the right side of the space
Comment 3 Andres Gonzalez 2020-04-14 11:03:03 PDT 
Created attachment 396438 [details]
Patch
Comment 4 Andres Gonzalez 2020-04-14 11:05:13 PDT 
(In reply to chris fleizach from comment #2)
> Comment on attachment 396422 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=396422&action=review
> 
> > Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:1479
> > +    NSArray* selectedChildren = attributeValue(m_element.get(), NSAccessibilitySelectedChildrenAttribute);
> 
> objectiveC pointers actually supposed to stay on the right side of the space

Fixed this one and a few other instances. Thanks.
Comment 5 EWS 2020-04-14 11:48:31 PDT 
Committed r260083: <https://trac.webkit.org/changeset/260083>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396438 [details].
Comment 6 Radar WebKit Bug Importer 2020-04-14 11:49:13 PDT 
<rdar://problem/61783089>