Bug 210495 – Factor PseudoElement creation calls into a single Element::ensurePseudoElement(pseudoId) method

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Antoine Quint]

Factor PseudoElement creation calls into a single Element::ensurePseudoElement(pseudoId) method

[Antoine Quint]

Created attachment 396414 [details]
Patch

[Antti Koivisto]

Comment on attachment 396414 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396414&action=review

> Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp:-123
> -            current.setBeforePseudoElement(newPseudoElement.releaseNonNull());
> -        else
> -            current.setAfterPseudoElement(newPseudoElement.releaseNonNull());

You can probably make these private now.

> Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp:113
> +    current.ensurePseudoElement(pseudoId);

pseudoElement =

[Antti Koivisto]

Comment on attachment 396414 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396414&action=review

> Source/WebCore/dom/Element.cpp:3484
> +PseudoElement* Element::ensurePseudoElement(PseudoId pseudoId)

I think this should return a reference. The assert could be a  release assert.

[Antoine Quint]

Created attachment 396428 [details]
Patch

[Antoine Quint]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 396414 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=396414&action=review
> 
> > Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp:-123
> > -            current.setBeforePseudoElement(newPseudoElement.releaseNonNull());
> > -        else
> > -            current.setAfterPseudoElement(newPseudoElement.releaseNonNull());
> 
> You can probably make these private now.

I think we can remove them altogether.

> > Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp:113
> > +    current.ensurePseudoElement(pseudoId);
> 
> pseudoElement =

Err… yeah!

[Antoine Quint]

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 396414 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=396414&action=review
> 
> > Source/WebCore/dom/Element.cpp:3484
> > +PseudoElement* Element::ensurePseudoElement(PseudoId pseudoId)
> 
> I think this should return a reference. The assert could be a  release
> assert.

Will do.

[Antoine Quint]

Created attachment 396432 [details]
Patch

[Antoine Quint]

Committed r260088: <https://trac.webkit.org/changeset/260088>

[Radar WebKit Bug Importer]

<rdar://problem/61784398>