Bug 210468 – axis in scroll-snap-type should be required

• Status: RESOLVED
• Resolution: FIXED
• Component: Scrolling

[Simon Fraser (smfr)]

We don't parse scroll-snap-type according to the spec:
https://drafts.csswg.org/css-scroll-snap-1/#scroll-snap-type

which means we're not compatible with Firefox and Chrome.

[Radar WebKit Bug Importer]

<rdar://problem/61746766>

[Simon Fraser (smfr)]

Actually we do parse it:

    auto firstValue = consumeIdent<CSSValueX, CSSValueY, CSSValueBlock, CSSValueInline, CSSValueBoth>(range);
    if (firstValue)
        secondValue = consumeIdent<CSSValueProximity, CSSValueMandatory>(range);
    else
        firstValue = consumeIdent<CSSValueNone, CSSValueProximity, CSSValueMandatory>(range);

but we treat the axis optional, when it should be required.

[Martin Robinson]

Created attachment 411435 [details]
Patch

[Martin Robinson]

*** Bug 187697 has been marked as a duplicate of this bug. ***

[Simon Fraser (smfr)]

Comment on attachment 411435 [details]
Patch

I'm concerned about web compat here. Does the snapping on https://music.apple.com still work?

[Majid Valipour]

FWIW, apple music scroll snapping works in Chrome which requires the new syntax.
Quick check on their home page showed they are using "scroll-snap-type: x mandatory".


Unfortunately chrome css data stats (https://chromestatus.com/metrics/css/popularity) do not tell you much about the value. But we can use it to compare usage of attributes that exclusively belong to the old syntax vs the new syntax: 


[exclusively old] <= 0.000001%
   scroll-snap-points-{x,y}, scroll-snap-coordinates, scroll-snap-destinations

[common in both] 2.090845%
  scroll-snap-types

[exclusively new] 2.090845%
  scroll-snap-align


This does suggest that old syntax is not being used much compared to the new one which could indicate that it is rare to have a single value that is not an axis as that is from old syntax and not valid in Chrome, Firefox, or Edge.

None of this is hard data on compat but hopefully helps.

[Majid Valipour]

scroll-snap-align usage should be 2.119231%

so
[exclusively old] <= 0.000001%
   scroll-snap-points-{x,y}, scroll-snap-coordinates, scroll-snap-destinations

[common in both] 2.090845%
  scroll-snap-type

[exclusively new] 2.119231%
  scroll-snap-align

[EWS]

Committed r268665: <https://trac.webkit.org/changeset/268665>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411435 [details].