Bug 210467 - YouTube sometimes navigates unexpectedly when invoking a context menu on a video link.
Summary: YouTube sometimes navigates unexpectedly when invoking a context menu on a vi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-13 16:53 PDT by Megan Gardner
Modified: 2020-04-14 09:38 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.81 KB, patch)
2020-04-13 16:57 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (1.86 KB, patch)
2020-04-13 17:11 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch for landing (1.85 KB, patch)
2020-04-14 09:15 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2020-04-13 16:53:59 PDT 
WebTouchEvents not cancelled soon enough in the life of a ContextMenu Gesture, causing TouchEvents and ContextMenus to fire at the same time.
Comment 1 Megan Gardner 2020-04-13 16:57:43 PDT 
Created attachment 396358 [details]
Patch
Comment 2 Megan Gardner 2020-04-13 16:58:48 PDT 
<rdar://problem/58841584>
Comment 3 Tim Horton 2020-04-13 17:03:26 PDT 
Comment on attachment 396358 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396358&action=review

At all possible to test?

> Source/WebKit/ChangeLog:3
> +        TouchEvents not cancelled soon enough in the life of a ContextMenu Gesture, causing TouchEvents and ContextMenus to fire at the same time.

How about "YouTube sometimes navigates unexpectedly when invoking a context menu on a video link" for the title.

> Source/WebKit/ChangeLog:9
> +        We need to cancel the touch events gesture when we are cleaing out things to make way for the ContextMenu Gesture and related events.

And some more words here. And no "cleaing out things".

Maybe something like:

"Cancel any outstanding touches tracked by WebTouchEventsGestureRecognizer, so that we dispatch `touchcancel` to the page instead of `touchend`, so that the page does not misinterpret context menu invocation as a tap."
Comment 4 Megan Gardner 2020-04-13 17:11:14 PDT 
Created attachment 396362 [details]
Patch
Comment 5 Megan Gardner 2020-04-14 09:15:58 PDT 
Created attachment 396425 [details]
Patch for landing
Comment 6 EWS 2020-04-14 09:38:55 PDT 
Committed r260077: <https://trac.webkit.org/changeset/260077>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396425 [details].