WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
210459
check-webkit-style should warn about attributes that appear after function definitions
https://bugs.webkit.org/show_bug.cgi?id=210459
Summary
check-webkit-style should warn about attributes that appear after function de...
David Kilzer (:ddkilzer)
Reported
2020-04-13 15:06:32 PDT
check-webkit-style should warn about attributes that appear after function definitions. Darin suggested it was better to be consistent and always put attributes before the function definition since placing them after the function definition (e.g., in a static function with no predeclaration) doesn't work.
Attachments
Patch v1
(4.87 KB, patch)
2020-04-13 15:14 PDT
,
David Kilzer (:ddkilzer)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1
2020-04-13 15:14:41 PDT
Created
attachment 396339
[details]
Patch v1
EWS
Comment 2
2020-04-13 17:32:30 PDT
Committed
r260051
: <
https://trac.webkit.org/changeset/260051
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 396339
[details]
.
Radar WebKit Bug Importer
Comment 3
2020-04-13 17:33:15 PDT
<
rdar://problem/61747702
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug