Bug 210442 – REGRESSION (r259900) : Speedometer failing on Catalina-Release-WK2-Perf bot

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryan Haddad]

Speedometer is failing on Catalina-Release-WK2-Perf bot as or r259905 due to spurious(?) console logging:

Running Speedometer (202 of 203)
ERROR: CONSOLE MESSAGE: DEBUG: -------------------------------
FAILED
Finished: 37.682425 s

https://build.webkit.org/builders/Apple-Catalina-Release-WK2-Perf/builds/660/steps/perf-test/logs/stdio

[Radar WebKit Bug Importer]

<rdar://problem/61727169>

[Alexey Proskuryakov]

This code in perftest.py needs to be updated after line number removal:

    _lines_to_ignore = [
        re.compile("^\s+$"),
        # Following are for handle existing test like Dromaeo
        re.compile(re.escape("""main frame - has 1 onunload handler(s)""")),
        re.compile('frame \"[^"]+\" - has \d+ onunload handler\(s\)'),
        # Following is for html5.html
        re.compile(re.escape("""Blocked access to external URL http://www.whatwg.org/specs/web-apps/current-work/""")),
        re.compile(r"CONSOLE MESSAGE: (line \d+: )?Blocked script execution in '[A-Za-z0-9\-\.:]+' because the document's frame is sandboxed and the 'allow-scripts' permission is not set."),
        re.compile(r"CONSOLE MESSAGE: (line \d+: )?Not allowed to load local resource"),
        # Speedometer 2.0
        re.compile(r'CONSOLE MESSAGE: line \d+: DEBUG: -------------------------------'),
        re.compile(r'CONSOLE MESSAGE: line \d+: DEBUG: Ember\s+: (\d\.)+'),
        re.compile(r'CONSOLE MESSAGE: line \d+: DEBUG: jQuery\s+: (\d\.)+'),
    ]

[Devin Rousso]

Created attachment 396363 [details]
Patch

[Stephanie Lewis]

Comment on attachment 396363 [details]
Patch

Looks fine to me as long as still runs on older builds.

[Devin Rousso]

Created attachment 396365 [details]
Patch

ensure backwards compatibility

[EWS]

Committed r260053: <https://trac.webkit.org/changeset/260053>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396365 [details].