Bug 210440 - Remove the "IgnoreViewportScalingConstraints" debug WebKit feature
Summary: Remove the "IgnoreViewportScalingConstraints" debug WebKit feature
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2020-04-13 10:35 PDT by Wenson Hsieh
Modified: 2020-04-14 10:17 PDT (History)
6 users (show)

See Also:


Attachments
Patch (5.86 KB, patch)
2020-04-13 10:42 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Patch (1.70 KB, patch)
2020-04-13 14:41 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-04-13 10:35:06 PDT
SSIA.
Comment 1 Wenson Hsieh 2020-04-13 10:42:37 PDT
Created attachment 396307 [details]
Patch
Comment 2 EWS 2020-04-13 12:42:38 PDT
Committed r260035: <https://trac.webkit.org/changeset/260035>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396307 [details].
Comment 3 Darin Adler 2020-04-13 14:20:55 PDT
Comment on attachment 396307 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396307&action=review

> Source/WebKit/UIProcess/API/C/WKPreferences.cpp:1612
>  void WKPreferencesSetIgnoreViewportScalingConstraints(WKPreferencesRef preferencesRef, bool enabled)

Best to omit or comment out unused argument names.

> Source/WebKit/UIProcess/API/C/WKPreferences.cpp:1617
>  bool WKPreferencesGetIgnoreViewportScalingConstraints(WKPreferencesRef preferencesRef)

Ditto.
Comment 4 Wenson Hsieh 2020-04-13 14:41:26 PDT
Reopening to attach new patch.
Comment 5 Wenson Hsieh 2020-04-13 14:41:27 PDT
Created attachment 396332 [details]
Patch
Comment 6 EWS 2020-04-14 10:17:50 PDT
Committed r260080: <https://trac.webkit.org/changeset/260080>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396332 [details].