Bug 21043 – REGRESSION: Leak of AnimationLists (and whole RenderStyles?)

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

The leaks bot is showing many leaks beneath accessAnimations(). See URL.

[Simon Fraser (smfr)]

I don't see any leaks when I run the animation tests:
wktests --debug --leaks LayoutTests/animations/
animations ..............
 ? checking for leaks in DumpRenderTree
 - no leaks found

(In reply to comment #1)
> I don't see any leaks when I run the animation tests:
> wktests --debug --leaks LayoutTests/animations/
> animations ..............
>  ? checking for leaks in DumpRenderTree
>  - no leaks found

The leaks bot is running Tiger. The leaks command tends to be better at finding leaks under Tiger, which is what the leaks bot is running. There is also a chance that the leaks has been fixed since r36763.

[Simon Fraser (smfr)]

Adding some printfs shows that RenderStyles are being leaked, but that may change when Chris fixes bug 20995.

[Simon Fraser (smfr)]

Still leaking after bug 20995 landed. We're leaking RenderStyles:

...
	WebCore::Element::attach()
	WebCore::Node::createRendererIfNeeded()
	WebCore::Node::styleForRenderer(WebCore::RenderObject*)
	WebCore::CSSStyleSelector::styleForElement(WebCore::Element*, WebCore::RenderStyle*, bool, bool)
	WebCore::RenderStyle::operator new(unsigned long, WebCore::RenderArena*)
	WebCore::RenderArena::allocate(unsigned long)
	malloc

[Simon Fraser (smfr)]

Created attachment 23920 [details]
Patch, changelog

[Anders Carlsson]

Comment on attachment 23920 [details]
Patch, changelog

r=me

[Simon Fraser (smfr)]

Committed r37078
	M	WebCore/ChangeLog
	M	WebCore/css/CSSStyleSelector.cpp
	M	WebCore/page/animation/KeyframeAnimation.cpp
r37078 = 8a565534699cd0513050a291fd34f009602cd903 (trunk)


Ran various animation tests with this fix, saw no leaks.