RESOLVED FIXED 210427
Fix clang static analyzer warnings about unused instance variables in WebIconDatabase, WKView 
https://bugs.webkit.org/show_bug.cgi?id=210427
Summary Fix clang static analyzer warnings about unused instance variables in WebIcon...
David Kilzer (:ddkilzer)
Reported 2020-04-13 08:15:18 PDT
Fix clang static analyzer warnings about unused instance variables in WebIconDatabase, WKView. Documentation says that __attribute__((unused)) should be used for this purpose: <https://clang-analyzer.llvm.org/faq.html#unused_ivar> Note that __attribute__((unused)) is already defined as UNUSED_FUNCTION in Compiler.h, but it's used for a different purpose: to denote unused parameters in a function definition in these source files: Source/WTF/wtf/AggregateLogger.h Source/WTF/wtf/Logger.h
Attachments
Patch v1 (5.50 KB, patch)
2020-04-13 08:20 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2020-04-13 08:20:19 PDT
Created attachment 396283 [details] Patch v1
EWS
Comment 2 2020-04-13 10:53:56 PDT
Committed r260027: <https://trac.webkit.org/changeset/260027> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396283 [details].
Radar WebKit Bug Importer
Comment 3 2020-04-13 10:54:18 PDT
<rdar://problem/61725350>
Note You need to log in before you can comment on or make changes to this bug.