Bug 210426 – Add ccls config file to the list of ignored files

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sergio Villar Senin]

Add ccls config file to the list of ignored files

[Sergio Villar Senin]

Created attachment 396280 [details]
Patch

[Sergio Villar Senin]

Ping reviewers.

ccls is a stand-alone server implementing the Language Server Protocol for C, C++, and Objective-C languages. It can be used with any editor which provides an LSP client implementation. It originates from cquery.

https://github.com/MaskRay/ccls/wiki

It's basically used to provide semantic highlight and code navigation to big source code bases as WebKit. Many editors support LSP servers.

[EWS]

Committed r260885: <https://trac.webkit.org/changeset/260885>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396280 [details].

[Radar WebKit Bug Importer]

<rdar://problem/62581559>

[Philippe Normand]

Comment on attachment 396280 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396280&action=review

> ChangeLog:9
> +        * .gitignore: ccls can read configuration options from a .ccls file in
> +        the project root directory. Let's just ignore it.

I don't understand the reason for this change. I've been using a local .ccls file for months, ccls running from the SDK actually needs such file. So I would like to revert this change and commit my .ccls file because I think it would be useful for a wider audience :)
Unless your IDE was generating a .ccls file? That seems to be what this patch implies, please elaborate :)

[Philippe Normand]

cat .ccls
%compile_commands.json
%h -x
%h c++-header
%h --include=config.h
%cpp --include=config.h

[Sergio Villar Senin]

(In reply to Philippe Normand from comment #5)
> Comment on attachment 396280 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=396280&action=review
> 
> > ChangeLog:9
> > +        * .gitignore: ccls can read configuration options from a .ccls file in
> > +        the project root directory. Let's just ignore it.
> 
> I don't understand the reason for this change. I've been using a local .ccls
> file for months, ccls running from the SDK actually needs such file. So I
> would like to revert this change and commit my .ccls file because I think it
> would be useful for a wider audience :)
> Unless your IDE was generating a .ccls file? That seems to be what this
> patch implies, please elaborate :)

Having a .ccls file is optional for ccls to work. That's the reason why I decided to add it to the list of ignored files instead of committing it. But I don't have a strong opinion here, i.e. I'm fine with you adding a .ccls file.