Bug 210416 – Add WARN_UNUSED_RETURN to decode methods in Source/WebCore

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[David Kilzer (:ddkilzer)]

Add WARN_UNUSED_RETURN to decode methods in Source/WebCore.

Found via:
$ ./Tools/Scripts/check-webkit-style --filter=-,+security/missing_warn_unused_return Source/WebCore

[David Kilzer (:ddkilzer)]

NOTE: Not every change is relate to CoreIPC decoding, but they're all decode methods that return bool.

[Radar WebKit Bug Importer]

<rdar://problem/61693462>

[David Kilzer (:ddkilzer)]

Created attachment 396251 [details]
Patch v1

[David Kilzer (:ddkilzer)]

(In reply to David Kilzer (:ddkilzer) from comment #3)
> Created attachment 396251 [details]
> Patch v1

I made some change to GTK files, so letting EWS run before requesting review.

[David Kilzer (:ddkilzer)]

Heh, this is blocked on Bug 210414 since that fixes a few issues found with these changes.

[David Kilzer (:ddkilzer)]

Note: No issues were found.  This is to add WARN_UNUSED_RETURN to decode methods returning `bool` to prevent future bugs.

[David Kilzer (:ddkilzer)]

Comment on attachment 396251 [details]
Patch v1

Obsoleting so I can repost the patch.  :(

Bug 209917: [ER] Add a way to retry EWS by rebuilding with a newer commit

[David Kilzer (:ddkilzer)]

(In reply to David Kilzer (:ddkilzer) from comment #7)
> Comment on attachment 396251 [details]
> Patch v1
> 
> Obsoleting so I can repost the patch.  :(
> 
> Bug 209917: [ER] Add a way to retry EWS by rebuilding with a newer commit

Aakash marked the patch for retry by EWS, so now this patch is ready for review.

[EWS]

Committed r260078: <https://trac.webkit.org/changeset/260078>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396251 [details].