Bug 21038 - Uncaught exceptions in regex replace callbacks crash webkit
Summary: Uncaught exceptions in regex replace callbacks crash webkit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P1 Critical
Assignee: Geoffrey Garen
URL: http://notlime.com/2008/regex_replace...
Keywords: HasReduction, InRadar
Depends on:
Blocks:
 
Reported: 2008-09-23 13:55 PDT by Mark Luffel
Modified: 2008-09-23 23:44 PDT (History)
1 user (show)

See Also:

Attachments
patch (8.01 KB, patch)
2008-09-23 23:37 PDT, Geoffrey Garen 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Luffel 2008-09-23 13:55:49 PDT 
Any javascript exception thrown from the callback to a string replacement will cause a crash. Catching the exception within the callback prevents the crash.

This is a regression relative to Safari 3.1.2
The bug is present in r35203 and r36766.
Comment 1 Mark Rowe (bdash) 2008-09-23 14:12:43 PDT 
<rdar://problem/6240812>
Comment 2 Geoffrey Garen 2008-09-23 23:37:30 PDT 
Created attachment 23739 [details]
patch
Comment 3 Geoffrey Garen 2008-09-23 23:44:35 PDT 
Committed revision 36842.