Bug 210367 - JSC should have a failure string repository.
Summary: JSC should have a failure string repository.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-10 18:10 PDT by Ross Kirsling
Modified: 2020-04-10 18:39 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2020-04-10 18:10:54 PDT
There are many places throughout our Intl API implementation in which ICU could have an internal failure.

JSC currently throws a JS error with a different message in each of these cases, but it might be better to have a single kind of error for all of them, like V8 and SM:
https://github.com/v8/v8/blob/master/src/common/message-template.h#L25
https://searchfox.org/mozilla-central/source/js/src/js.msg#536
Comment 1 Keith Miller 2020-04-10 18:20:37 PDT
Oh, I was thinking of having one repo of all our failure strings so they're consistent.
Comment 2 Ross Kirsling 2020-04-10 18:39:33 PDT
Oh that's even more ambitious! I like it.