Bug 210364 - When drawing an image srcRect and imageRect have to be in the orientation of destRect
Summary: When drawing an image srcRect and imageRect have to be in the orientation of ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-10 17:32 PDT by Said Abou-Hallawa
Modified: 2020-05-08 14:33 PDT (History)
7 users (show)

See Also:

Attachments
Patch (10.72 KB, patch)
2020-04-10 17:55 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2020-04-10 17:32:58 PDT 
When passing ImageOrientation::None to any drawImage() function, srcRect and imageRect have to be calculated with this orientation. There are few places where the size of the image is calculated with ImageOrientation::FromImage because it is the default.
Comment 1 Said Abou-Hallawa 2020-04-10 17:55:56 PDT 
Created attachment 396140 [details]
Patch
Comment 2 EWS 2020-04-13 09:43:26 PDT 
Committed r260016: <https://trac.webkit.org/changeset/260016>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396140 [details].
Comment 3 Radar WebKit Bug Importer 2020-04-13 09:44:17 PDT 
<rdar://problem/61720495>
Comment 4 Antoine Quint 2020-05-01 01:33:31 PDT 
This was reverted in r260989.
Comment 5 Said Abou-Hallawa 2020-05-08 14:33:45 PDT 
It was reinstated in:

Committed r261162: <https://trac.webkit.org/changeset/261162>