Bug 21036 - Inspecting a node after reloading the page with the Inspector open does not reveal the node
Summary: Inspecting a node after reloading the page with the Inspector open does not r...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-23 13:07 PDT by Timothy Hatcher
Modified: 2008-09-23 19:14 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (5.96 KB, patch)
2008-09-23 13:48 PDT, Timothy Hatcher 		kmccullough: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2008-09-23 13:07:41 PDT 
Inspecting a node after reloading the page with the Inspector open does not reveal the node.

This is happening because the TreeOutline thinks it knows about TreeElemnts that no long exist in the tree for some nodes.
Comment 1 Timothy Hatcher 2008-09-23 13:48:53 PDT 
Created attachment 23716 [details]
Proposed patch
Comment 2 Kevin McCullough 2008-09-23 14:21:24 PDT 
Comment on attachment 23716 [details]
Proposed patch

-    if (child.treeOutline)
+    if (child.treeOutline) {
         child.treeOutline._forgetTreeElement(child);
+        child.treeOutline._forgetChildrenRecursive(child);
+    }

Should we always assume _forgetChildrenRecursive should follow _forgetTreeElement and thus include it in _forgetTree Element?
Comment 3 Timothy Hatcher 2008-09-23 19:14:19 PDT 
Landed in r36828.