Bug 210352 - [iOS] Add message filtering to all iokit open rules
Summary: [iOS] Add message filtering to all iokit open rules
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-10 13:26 PDT by Per Arne Vollan
Modified: 2020-04-13 09:48 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.20 KB, patch)
2020-04-10 13:30 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (4.31 KB, patch)
2020-04-10 13:36 PDT, Per Arne Vollan 		sam: review+
Details | Formatted Diff | Diff
Patch (4.33 KB, patch)
2020-04-13 09:28 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-04-10 13:26:46 PDT 
Apply message filtering to all iokit-open rules in the WebContent process' sandbox on iOS.
Comment 1 Radar WebKit Bug Importer 2020-04-10 13:27:39 PDT 
<rdar://problem/61601634>
Comment 2 Per Arne Vollan 2020-04-10 13:30:17 PDT 
Created attachment 396116 [details]
Patch
Comment 3 Per Arne Vollan 2020-04-10 13:36:52 PDT 
Created attachment 396117 [details]
Patch
Comment 4 Sam Weinig 2020-04-12 11:59:33 PDT 
Comment on attachment 396117 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396117&action=review

> Source/WebKit/ChangeLog:8
> +        Apply message filtering with reports and telemetry to all iokit-open rules in the WebContent process' sandbox on iOS.

Why? What are you hoping to learn here?
Comment 5 Sam Weinig 2020-04-13 08:12:37 PDT 
Comment on attachment 396117 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396117&action=review

>> Source/WebKit/ChangeLog:8
>> +        Apply message filtering with reports and telemetry to all iokit-open rules in the WebContent process' sandbox on iOS.
> 
> Why? What are you hoping to learn here?

I think saying something like "to gain a better understanding of which iokit-open rules we can investigate" would add a lot here.
Comment 6 Per Arne Vollan 2020-04-13 09:28:13 PDT 
Created attachment 396294 [details]
Patch
Comment 7 Per Arne Vollan 2020-04-13 09:28:37 PDT 
(In reply to Sam Weinig from comment #5)
> Comment on attachment 396117 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=396117&action=review
> 
> >> Source/WebKit/ChangeLog:8
> >> +        Apply message filtering with reports and telemetry to all iokit-open rules in the WebContent process' sandbox on iOS.
> > 
> > Why? What are you hoping to learn here?
> 
> I think saying something like "to gain a better understanding of which
> iokit-open rules we can investigate" would add a lot here.

Fixed.

Thanks for reviewing!
Comment 8 EWS 2020-04-13 09:48:33 PDT 
Committed r260017: <https://trac.webkit.org/changeset/260017>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396294 [details].