This test is flaky failing on Mac wk2 Debug. The flaky failures are apparent throughout the visible history.
@@ -1,13 +1,5 @@
-Testing the controls bar fades out as expected after the auto-hide delay expires upon first play.
+#PID UNRESPONSIVE - WebKitTestRunner (pid 82861)
+FAIL: Timed out waiting for notifyDone to be called
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS !!shadowRoot.querySelector('.media-controls') became true
-PASS shadowRoot.querySelector('.media-controls').classList.contains('faded') became false
-PASS shadowRoot.querySelector('.media-controls').classList.contains('faded') became true
-PASS successfullyParsed is true
I have marked this test as flaky timing out while this issue is investigated.
Using the test list for the worker where this test times out in the most recent failure reproduces the issue, see https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK2%20%28Tests%29/builds/8860.
Created attachment 396652 [details]
Comment on attachment 396652 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=396652&action=review
> + This test had several things wrong about it. First, it manually created a MediaController in the test page and set a custom auto-hide delay on it.
> + However, it would test the proper behavior of the auto-hide behavior on the MediaController created by the media element, querying the state of
> + the media controls markup within that media element's shadow root. In that world, the auto-hide delay was the default delay, and not the custom
> + one set on the page-created MediaController.
> + The cause of the timeout was that the media clip used in this test is barely longer than the auto-hide delay, and it could happen that under slow
> + conditions, the media would end and the auto-hide timer would never have a chance to fire since it would be canceled due to auto-hide being disabled
> + when the media is not playing, such as when it ended.
> + We make this test saner and more realistic by not customizing the auto-hide delay, removing the page MediaController and simply setting "loop" on the
> + media element such that it never stops playing, givin the auto-hide timer additional time to fire with no risk of it being canceled by the media ending.
A+ for the ChangeLog comments!
Committed r260189: <https://trac.webkit.org/changeset/260189>