RESOLVED FIXED 210324
Web Inspector: Debugger: add a Step next that steps by expression
https://bugs.webkit.org/show_bug.cgi?id=210324
Summary Web Inspector: Debugger: add a Step next that steps by expression
Devin Rousso
Reported 2020-04-09 23:58:58 PDT
When debugging minified code, if statement trees are often squished together with parenthesis and logical operators. To give an example, ``` a() && b() && c(); ``` with the current set of stepping actions available right now, the only way to reach `c()` is to Step into and Step out of each function until `c()` is reached, which is a process that has many opportunities for a mistake. Step next would act like Step over, except that instead of stepping statement-by-statement (e.g. Step next would step over the entire line until whatever is after the `;`) it would step expression-by-expression, but without stepping into any function calls. Basically, it's a hybrid of Step over and Step into in that it steps to the next pause opportunity within the current (or ancestor) call frame.
Attachments
Patch (59.00 KB, patch)
2020-04-10 00:05 PDT, Devin Rousso
no flags
[Video] After Patch is applied (1.95 MB, video/quicktime)
2020-04-10 00:13 PDT, Devin Rousso
no flags
Patch (59.73 KB, patch)
2020-04-10 00:19 PDT, Devin Rousso
no flags
Patch (59.73 KB, patch)
2020-04-14 16:04 PDT, Devin Rousso
no flags
Devin Rousso
Comment 1 2020-04-10 00:05:51 PDT
EWS Watchlist
Comment 2 2020-04-10 00:06:32 PDT
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.
Devin Rousso
Comment 3 2020-04-10 00:13:50 PDT
Created attachment 396056 [details] [Video] After Patch is applied
Devin Rousso
Comment 4 2020-04-10 00:19:00 PDT
Created attachment 396057 [details] Patch oops, forgot the new image 😅
Timothy Hatcher
Comment 5 2020-04-14 13:59:32 PDT
Comment on attachment 396057 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396057&action=review > Source/JavaScriptCore/inspector/protocol/Debugger.json:199 > + "name": "stepNext", stepToNextExpression? stepOverExpression?
Devin Rousso
Comment 6 2020-04-14 16:04:05 PDT
Created attachment 396469 [details] Patch rename "Step next" to just "Step"
EWS
Comment 7 2020-04-14 19:35:08 PDT
Committed r260113: <https://trac.webkit.org/changeset/260113> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396469 [details].
Radar WebKit Bug Importer
Comment 8 2020-04-14 19:36:17 PDT
Note You need to log in before you can comment on or make changes to this bug.