Bug 210318 - Hit-testing a WebTiledBackingLayer with an animation asserts
Summary: Hit-testing a WebTiledBackingLayer with an animation asserts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-09 20:46 PDT by Simon Fraser (smfr)
Modified: 2020-04-10 20:01 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.45 KB, patch)
2020-04-09 20:47 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (5.47 KB, patch)
2020-04-09 20:56 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (5.47 KB, patch)
2020-04-09 21:02 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-04-09 20:46:11 PDT 
Hit-testing a WebTiledBackingLayer with an animation asserts
Comment 1 Simon Fraser (smfr) 2020-04-09 20:47:58 PDT 
Created attachment 396040 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-04-09 20:48:22 PDT 
<rdar://problem/61561048>
Comment 3 Simon Fraser (smfr) 2020-04-09 20:56:32 PDT 
Created attachment 396041 [details]
Patch
Comment 4 Simon Fraser (smfr) 2020-04-09 21:02:02 PDT 
Created attachment 396042 [details]
Patch
Comment 5 EWS 2020-04-10 08:27:55 PDT 
Committed r259871: <https://trac.webkit.org/changeset/259871>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396042 [details].
Comment 6 Alexey Proskuryakov 2020-04-10 13:34:47 PDT 
Comment on attachment 396042 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396042&action=review

> Source/WebCore/platform/graphics/ca/cocoa/WebTiledBackingLayer.mm:-58
> -    ASSERT_NOT_REACHED();

FWIW, the assertion was added with this comment: "Implement this and assert that it's never reached. We should never create presentation layers since we don't animate this layer."
Comment 7 Simon Fraser (smfr) 2020-04-10 20:01:09 PDT 
We plainly do animate this layer.