Bug 210312 – Don't emit the rhs twice in `AssignResolveNode`

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Devin Rousso]

[Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp](http://trac.webkit.org/changeset/259781/webkit/trunk/Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp):
```
    RefPtr<RegisterID> result = generator.emitNode(dst, m_right);
    if (isReadOnly) {
        RegisterID* result = generator.emitNode(dst, m_right); // Execute side effects first.
```

[Devin Rousso]

Created attachment 396026 [details]
Patch

[Devin Rousso]

Created attachment 396027 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 396027 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396027&action=review

r=me

> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:2913
> +    RefPtr<RegisterID> result = generator.emitNode(dst, m_right); // Execute side effects first.

Nice.

[EWS]

Committed r259841: <https://trac.webkit.org/changeset/259841>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396027 [details].

[Radar WebKit Bug Importer]

<rdar://problem/61552585>

[Saam Barati]

Comment on attachment 396027 [details]
Patch

No test?

[Ross Kirsling]

(In reply to Saam Barati from comment #6)
> Comment on attachment 396027 [details]
> Patch
> 
> No test?

This didn't cause incorrect behavior, it was just redundant.