Bug 210310 - Fix failing legacy CSP tests by converting them to modern tests instead.
Summary: Fix failing legacy CSP tests by converting them to modern tests instead.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-09 16:10 PDT by Truitt Savell
Modified: 2020-04-10 10:06 PDT (History)
6 users (show)

See Also:


Attachments
Patch (13.74 KB, patch)
2020-04-09 17:31 PDT, Keith Miller
no flags Details | Formatted Diff | Diff
Patch (13.69 KB, patch)
2020-04-09 17:34 PDT, Keith Miller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2020-04-09 16:10:58 PDT
http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked.html

This test began failing after the changes in https://trac.webkit.org/changeset/259829/webkit

history:
https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fsecurity%2FcontentSecurityPolicy%2F1.1%2Fform-action-src-redirect-blocked.html

Diff:
--- /Volumes/Data/slave/catalina-release-tests-wk1/build/layout-test-results/http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked-expected.txt
+++ /Volumes/Data/slave/catalina-release-tests-wk1/build/layout-test-results/http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked-actual.txt
@@ -3,3 +3,8 @@
 Parameters:
 
 
+
+============== Back Forward List ==============
+        http://127.0.0.1:8000/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked.html  **nav target**
+curr->  http://localhost:8000/navigation/resources/form-target.pl  **nav target**
+===============================================
Comment 1 Radar WebKit Bug Importer 2020-04-09 16:11:31 PDT
<rdar://problem/61547615>
Comment 2 Keith Miller 2020-04-09 16:23:28 PDT
Hmm, interestingly, it looks like it only fails on WK1...
Comment 3 Keith Miller 2020-04-09 17:31:47 PDT
Created attachment 396029 [details]
Patch
Comment 4 Keith Miller 2020-04-09 17:34:23 PDT
Created attachment 396030 [details]
Patch
Comment 5 Alexey Proskuryakov 2020-04-09 17:59:07 PDT
Comment on attachment 396030 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396030&action=review

> LayoutTests/ChangeLog:8
> +        Convert these tests from verifying the (now removed) X-WebKit-CSP

Were all of these tests failing, or only one? The others would be pretty bad tests if they continued to pass after support for the header field was removed.
Comment 6 Keith Miller 2020-04-09 20:58:56 PDT
(In reply to Alexey Proskuryakov from comment #5)
> Comment on attachment 396030 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=396030&action=review
> 
> > LayoutTests/ChangeLog:8
> > +        Convert these tests from verifying the (now removed) X-WebKit-CSP
> 
> Were all of these tests failing, or only one? The others would be pretty bad
> tests if they continued to pass after support for the header field was
> removed.

I changed their behavior to match the new X-WebKit-CSP behavior but I think the changed tests are not really meaningful. 1) because there's other tests that we don't respect the old headers 2) there's no other equivalent tests that the modern headers.
Comment 7 Aakash Jain 2020-04-10 07:42:56 PDT
We should land the fix soon. It's slowing down mac-wk1 ews queue.
Comment 8 Daniel Bates 2020-04-10 09:44:37 PDT
Comment on attachment 396030 [details]
Patch

Looks much better.
Comment 9 EWS 2020-04-10 10:06:58 PDT
Committed r259880: <https://trac.webkit.org/changeset/259880>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396030 [details].