http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked.html This test began failing after the changes in https://trac.webkit.org/changeset/259829/webkit history: https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fsecurity%2FcontentSecurityPolicy%2F1.1%2Fform-action-src-redirect-blocked.html Diff: --- /Volumes/Data/slave/catalina-release-tests-wk1/build/layout-test-results/http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked-expected.txt +++ /Volumes/Data/slave/catalina-release-tests-wk1/build/layout-test-results/http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked-actual.txt @@ -3,3 +3,8 @@ Parameters: + +============== Back Forward List ============== + http://127.0.0.1:8000/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked.html **nav target** +curr-> http://localhost:8000/navigation/resources/form-target.pl **nav target** +===============================================
<rdar://problem/61547615>
Hmm, interestingly, it looks like it only fails on WK1...
Created attachment 396029 [details] Patch
Created attachment 396030 [details] Patch
Comment on attachment 396030 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396030&action=review > LayoutTests/ChangeLog:8 > + Convert these tests from verifying the (now removed) X-WebKit-CSP Were all of these tests failing, or only one? The others would be pretty bad tests if they continued to pass after support for the header field was removed.
(In reply to Alexey Proskuryakov from comment #5) > Comment on attachment 396030 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=396030&action=review > > > LayoutTests/ChangeLog:8 > > + Convert these tests from verifying the (now removed) X-WebKit-CSP > > Were all of these tests failing, or only one? The others would be pretty bad > tests if they continued to pass after support for the header field was > removed. I changed their behavior to match the new X-WebKit-CSP behavior but I think the changed tests are not really meaningful. 1) because there's other tests that we don't respect the old headers 2) there's no other equivalent tests that the modern headers.
We should land the fix soon. It's slowing down mac-wk1 ews queue.
Comment on attachment 396030 [details] Patch Looks much better.
Committed r259880: <https://trac.webkit.org/changeset/259880> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396030 [details].