RESOLVED FIXED 21030
The JS debugger breaks on the do of a do-while not the while (where the conditional statement is) 
https://bugs.webkit.org/show_bug.cgi?id=21030
Summary The JS debugger breaks on the do of a do-while not the while (where the condi...
Kevin McCullough
Reported 2008-09-23 11:20:10 PDT
<rdar://problem/6204189> the do get's hit because statementListEmitCode emits a debug hook for the first line of the statement but for do-whiiles we really want it to be on the last line.
Attachments
Test file which shows the issue (1.00 KB, text/html)
2008-09-23 11:21 PDT, Kevin McCullough 		no flags
Details
Patch (2.32 KB, patch)
2008-09-23 11:25 PDT, Kevin McCullough 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kevin McCullough
Comment 1 2008-09-23 11:21:35 PDT
Created attachment 23709 [details] Test file which shows the issue
Kevin McCullough
Comment 2 2008-09-23 11:25:26 PDT
Created attachment 23710 [details] Patch
Darin Adler
Comment 3 2008-09-23 11:28:20 PDT
Comment on attachment 23710 [details] Patch r=me Is there any way to do automated testing of debugger hook changes? + * kjs/nodes.h: + (JSC::StatementNode::): + (JSC::DoWhileNode::): This is kind of weak. When prepare-ChangeLog puts nonsense in the ChangeLog you should fix it instead of just checking it in.
Kevin McCullough
Comment 4 2008-09-23 11:40:16 PDT
Committed revision 36809. I fixed the change log and I'll look into automated debugger hook testing.
Note You need to log in before you can comment on or make changes to this bug.