Bug 21030 - The JS debugger breaks on the do of a do-while not the while (where the conditional statement is)
Summary: The JS debugger breaks on the do of a do-while not the while (where the condi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Kevin McCullough
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2008-09-23 11:20 PDT by Kevin McCullough
Modified: 2008-09-23 11:40 PDT (History)
0 users

See Also:


Attachments
Test file which shows the issue (1.00 KB, text/html)
2008-09-23 11:21 PDT, Kevin McCullough
no flags Details
Patch (2.32 KB, patch)
2008-09-23 11:25 PDT, Kevin McCullough
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin McCullough 2008-09-23 11:20:10 PDT
<rdar://problem/6204189>

the do get's hit because statementListEmitCode emits a debug hook for the first line of the statement but for do-whiiles we really want it to be on the last line.
Comment 1 Kevin McCullough 2008-09-23 11:21:35 PDT
Created attachment 23709 [details]
Test file which shows the issue
Comment 2 Kevin McCullough 2008-09-23 11:25:26 PDT
Created attachment 23710 [details]
Patch
Comment 3 Darin Adler 2008-09-23 11:28:20 PDT
Comment on attachment 23710 [details]
Patch

r=me

Is there any way to do automated testing of debugger hook changes?

+        * kjs/nodes.h:
+        (JSC::StatementNode::):
+        (JSC::DoWhileNode::):

This is kind of weak. When prepare-ChangeLog puts nonsense in the ChangeLog you should fix it instead of just checking it in.
Comment 4 Kevin McCullough 2008-09-23 11:40:16 PDT
Committed revision 36809.

I fixed the change log and I'll look into automated debugger hook testing.