Bug 210295 - Fix for crash in test accessibility/Mac/aria-grid-with-strange-hierarchy.html in isolated tree mode.
Summary: Fix for crash in test accessibility/Mac/aria-grid-with-strange-hierarchy.html...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-09 12:07 PDT by Andres Gonzalez
Modified: 2020-04-09 14:56 PDT (History)
9 users (show)

See Also:

Attachments
Patch (7.97 KB, patch)
2020-04-09 12:28 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (7.97 KB, patch)
2020-04-09 13:18 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-04-09 12:07:57 PDT 
Fix for crash in test accessibility/Mac/aria-grid-with-strange-hierarchy.html in isolated tree mode.
Comment 1 Andres Gonzalez 2020-04-09 12:28:23 PDT 
Created attachment 395989 [details]
Patch
Comment 2 chris fleizach 2020-04-09 12:35:53 PDT 
Comment on attachment 395989 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395989&action=review

> Source/WebCore/ChangeLog:20
> +        - Added strcter assert checks to catch problems with the management of

stricter

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:217
>      auto object = nodeForID(axObjectID);

should we assert that the lock is hold in nodeForID() ?
Comment 3 Andres Gonzalez 2020-04-09 13:18:51 PDT 
Created attachment 395995 [details]
Patch
Comment 4 EWS 2020-04-09 14:55:57 PDT 
Committed r259832: <https://trac.webkit.org/changeset/259832>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395995 [details].
Comment 5 Radar WebKit Bug Importer 2020-04-09 14:56:14 PDT 
<rdar://problem/61541961>