Followup to <https://webkit.org/b/210215>.
Created attachment 395985 [details] Patch
Comment on attachment 395985 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395985&action=review > Source/WebCore/editing/TextManipulationController.cpp:379 > + if (start.isNull() || end.isNull()) I think this part landed already?
Thanks for the review! (In reply to Tim Horton from comment #2) > Comment on attachment 395985 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=395985&action=review > > > Source/WebCore/editing/TextManipulationController.cpp:379 > > + if (start.isNull() || end.isNull()) > > I think this part landed already? Ah, this was a different null check (at the top of TextManipulationController::observeParagraphs). Technically, the early `continue;` here obviates the need for the early return in TextManipulationController::observeParagraphs. I considered reverting the other early return, but since there is at least one other call site of observeParagraphs (and possibly more in the future), I don’t think it’s a bad idea to keep observeParagraphs robust against null positions.
Created attachment 395987 [details] Fix a minor typo
Committed r259819: <https://trac.webkit.org/changeset/259819> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395987 [details].