Bug 210294 - Add an API test for <https://trac.webkit.org/r259766>
Summary: Add an API test for <https://trac.webkit.org/r259766>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2020-04-09 11:34 PDT by Wenson Hsieh
Modified: 2020-04-09 13:16 PDT (History)
8 users (show)

See Also:


Attachments
Patch (5.31 KB, patch)
2020-04-09 12:02 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Fix a minor typo (5.31 KB, patch)
2020-04-09 12:09 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-04-09 11:34:27 PDT
Followup to <https://webkit.org/b/210215>.
Comment 1 Wenson Hsieh 2020-04-09 12:02:39 PDT Comment hidden (obsolete)
Comment 2 Tim Horton 2020-04-09 12:04:21 PDT
Comment on attachment 395985 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395985&action=review

> Source/WebCore/editing/TextManipulationController.cpp:379
> +            if (start.isNull() || end.isNull())

I think this part landed already?
Comment 3 Wenson Hsieh 2020-04-09 12:07:10 PDT
Thanks for the review!

(In reply to Tim Horton from comment #2)
> Comment on attachment 395985 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=395985&action=review
> 
> > Source/WebCore/editing/TextManipulationController.cpp:379
> > +            if (start.isNull() || end.isNull())
> 
> I think this part landed already?

Ah, this was a different null check (at the top of TextManipulationController::observeParagraphs).

Technically, the early `continue;` here obviates the need for the early return in TextManipulationController::observeParagraphs. I considered reverting the other early return, but since there is at least one other call site of observeParagraphs (and possibly more in the future), I don’t think it’s a bad idea to keep observeParagraphs robust against null positions.
Comment 4 Wenson Hsieh 2020-04-09 12:09:36 PDT
Created attachment 395987 [details]
Fix a minor typo
Comment 5 EWS 2020-04-09 13:16:43 PDT
Committed r259819: <https://trac.webkit.org/changeset/259819>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395987 [details].