Bug 210292 - [Flatpak SDK] Flatpak build broken when using 'git config core.webkitbranchbuild=true'
Summary: [Flatpak SDK] Flatpak build broken when using 'git config core.webkitbranchbu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: PC Linux
: P2 Blocker
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-09 11:06 PDT by Nikolas Zimmermann
Modified: 2020-04-10 04:07 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.88 KB, patch)
2020-04-10 03:29 PDT, Philippe Normand 		zan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2020-04-09 11:06:13 PDT 
The baseProductDir() contains the git branch name WebKitBuild/my_branch if that option is activated.
The flatpak detection assumes that $baseProductDir/UserFlatpak holds the Flatpak data, that is no longer true within this setup.

Let's think about how to fix this :-)
Comment 1 Philippe Normand 2020-04-10 03:29:14 PDT 
Created attachment 396072 [details]
Patch
Comment 2 Philippe Normand 2020-04-10 04:07:00 PDT 
Committed r259864: <https://trac.webkit.org/changeset/259864>
Comment 3 Radar WebKit Bug Importer 2020-04-10 04:07:11 PDT 
<rdar://problem/61577164>