RESOLVED FIXED 210292
[Flatpak SDK] Flatpak build broken when using 'git config core.webkitbranchbuild=true' 
https://bugs.webkit.org/show_bug.cgi?id=210292
Summary [Flatpak SDK] Flatpak build broken when using 'git config core.webkitbranchbu...
Nikolas Zimmermann
Reported 2020-04-09 11:06:13 PDT
The baseProductDir() contains the git branch name WebKitBuild/my_branch if that option is activated. The flatpak detection assumes that $baseProductDir/UserFlatpak holds the Flatpak data, that is no longer true within this setup. Let's think about how to fix this :-)
Attachments
Patch (3.88 KB, patch)
2020-04-10 03:29 PDT, Philippe Normand 		zan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2020-04-10 03:29:14 PDT
Created attachment 396072 [details] Patch
Philippe Normand
Comment 2 2020-04-10 04:07:00 PDT
Committed r259864: <https://trac.webkit.org/changeset/259864>
Radar WebKit Bug Importer
Comment 3 2020-04-10 04:07:11 PDT
<rdar://problem/61577164>
Note You need to log in before you can comment on or make changes to this bug.