Bug 210289 - [ews] Add unit tests to ensure that step names are valid identifier
Summary: [ews] Add unit tests to ensure that step names are valid identifier
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-09 10:20 PDT by Aakash Jain
Modified: 2020-04-09 12:43 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.46 KB, patch)
2020-04-09 10:25 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-04-09 10:20:11 PDT
Add unit tests to ensure that step names used in steps.py are valid identifier (e.g.: doesn't contain space). Buildbot 0.9+ requires step names to be identifiers, and identifier can't contain spaces http://docs.buildbot.net/0.9.8/manual/installation/nine-upgrade.html#identifiers
Comment 1 Aakash Jain 2020-04-09 10:25:35 PDT
Created attachment 395973 [details]
Patch
Comment 2 Aakash Jain 2020-04-09 10:28:04 PDT
This would prevent people from accidentally using spaces in step name (e.g.: https://bugs.webkit.org/show_bug.cgi?id=210202#c15)
Comment 3 EWS 2020-04-09 12:42:08 PDT
Committed r259815: <https://trac.webkit.org/changeset/259815>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395973 [details].
Comment 4 Radar WebKit Bug Importer 2020-04-09 12:43:17 PDT
<rdar://problem/61533468>