Bug 210283 – Reset view navigation gesture state between tests

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Reset view navigation gesture state between tests

[Simon Fraser (smfr)]

Created attachment 395966 [details]
Patch

[Tim Horton]

Comment on attachment 395966 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395966&action=review

> Source/WebKit/UIProcess/API/C/WKPage.cpp:2728
> +{

If you put this on WKWebView instead you can avoid the pageclient hits AND avoid expanding the C API.

[Simon Fraser (smfr)]

Created attachment 395975 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/61526278>

[Simon Fraser (smfr)]

(In reply to Tim Horton from comment #2)
> Comment on attachment 395966 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=395966&action=review
> 
> > Source/WebKit/UIProcess/API/C/WKPage.cpp:2728
> > +{
> 
> If you put this on WKWebView instead you can avoid the pageclient hits AND
> avoid expanding the C API.

Yeah I wasn't sure about that. Will do.

[Simon Fraser (smfr)]

Created attachment 395979 [details]
Patch

[EWS]

Committed r259818: <https://trac.webkit.org/changeset/259818>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395979 [details].

[David Kilzer (:ddkilzer)]

This is causing crashes on three ios-wk2 tests in EWS and on build.webkit.org:

swipe/main-frame-pinning-requirement.html
swipe/pushState-programmatic-back-while-swiping-crash.html
webgl/1.0.3/conformance/ogles/GL/lessThan/lessThan_001_to_008.html

Example test run:  <https://build.webkit.org/results/Apple%20iOS%2013%20Simulator%20Release%20WK2%20(Tests)/r259848%20(3630)/results.html>

[David Kilzer (:ddkilzer)]

See also results:

<https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&test=swipe%2FpushState-programmatic-back-while-swiping-crash.html&test=webgl%2F1.0.3%2Fconformance%2Fogles%2FGL%2Ffaceforward%2Ffaceforward_001_to_006.html&test=swipe%2FpushState-programmatic-back-while-swiping-crash.html&platform=ios>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 210330

[David Kilzer (:ddkilzer)]

(In reply to David Kilzer (:ddkilzer) from comment #8)
> This is causing crashes on three ios-wk2 tests in EWS and on
> build.webkit.org:
> 
> swipe/main-frame-pinning-requirement.html
> swipe/pushState-programmatic-back-while-swiping-crash.html
> webgl/1.0.3/conformance/ogles/GL/lessThan/lessThan_001_to_008.html
> 
> Example test run: 
> <https://build.webkit.org/results/
> Apple%20iOS%2013%20Simulator%20Release%20WK2%20(Tests)/r259848%20(3630)/
> results.html>

BTW, this looks kind of like a use after free based on the crash logs.

[Simon Fraser (smfr)]

iOS WK2 EWS is so slow that I can't wait for it.

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/259883/webkit