Bug 210283 - Reset view navigation gesture state between tests
Summary: Reset view navigation gesture state between tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on: 210330
Blocks:
  Show dependency treegraph
 
Reported: 2020-04-09 09:39 PDT by Simon Fraser (smfr)
Modified: 2020-04-13 10:21 PDT (History)
5 users (show)

See Also:


Attachments
Patch (13.65 KB, patch)
2020-04-09 09:43 PDT, Simon Fraser (smfr)
thorton: review+
Details | Formatted Diff | Diff
Patch (13.70 KB, patch)
2020-04-09 10:35 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (10.26 KB, patch)
2020-04-09 11:17 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-04-09 09:39:52 PDT
Reset view navigation gesture state between tests
Comment 1 Simon Fraser (smfr) 2020-04-09 09:43:12 PDT
Created attachment 395966 [details]
Patch
Comment 2 Tim Horton 2020-04-09 10:20:21 PDT
Comment on attachment 395966 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395966&action=review

> Source/WebKit/UIProcess/API/C/WKPage.cpp:2728
> +{

If you put this on WKWebView instead you can avoid the pageclient hits AND avoid expanding the C API.
Comment 3 Simon Fraser (smfr) 2020-04-09 10:35:04 PDT
Created attachment 395975 [details]
Patch
Comment 4 Radar WebKit Bug Importer 2020-04-09 10:50:01 PDT
<rdar://problem/61526278>
Comment 5 Simon Fraser (smfr) 2020-04-09 10:50:18 PDT
(In reply to Tim Horton from comment #2)
> Comment on attachment 395966 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=395966&action=review
> 
> > Source/WebKit/UIProcess/API/C/WKPage.cpp:2728
> > +{
> 
> If you put this on WKWebView instead you can avoid the pageclient hits AND
> avoid expanding the C API.

Yeah I wasn't sure about that. Will do.
Comment 6 Simon Fraser (smfr) 2020-04-09 11:17:48 PDT
Created attachment 395979 [details]
Patch
Comment 7 EWS 2020-04-09 13:11:29 PDT
Committed r259818: <https://trac.webkit.org/changeset/259818>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395979 [details].
Comment 8 David Kilzer (:ddkilzer) 2020-04-10 03:10:22 PDT
This is causing crashes on three ios-wk2 tests in EWS and on build.webkit.org:

swipe/main-frame-pinning-requirement.html
swipe/pushState-programmatic-back-while-swiping-crash.html
webgl/1.0.3/conformance/ogles/GL/lessThan/lessThan_001_to_008.html

Example test run:  <https://build.webkit.org/results/Apple%20iOS%2013%20Simulator%20Release%20WK2%20(Tests)/r259848%20(3630)/results.html>
Comment 10 WebKit Commit Bot 2020-04-10 03:16:36 PDT
Re-opened since this is blocked by bug 210330
Comment 11 David Kilzer (:ddkilzer) 2020-04-10 08:36:11 PDT
(In reply to David Kilzer (:ddkilzer) from comment #8)
> This is causing crashes on three ios-wk2 tests in EWS and on
> build.webkit.org:
> 
> swipe/main-frame-pinning-requirement.html
> swipe/pushState-programmatic-back-while-swiping-crash.html
> webgl/1.0.3/conformance/ogles/GL/lessThan/lessThan_001_to_008.html
> 
> Example test run: 
> <https://build.webkit.org/results/
> Apple%20iOS%2013%20Simulator%20Release%20WK2%20(Tests)/r259848%20(3630)/
> results.html>

BTW, this looks kind of like a use after free based on the crash logs.
Comment 12 Simon Fraser (smfr) 2020-04-10 10:11:36 PDT
iOS WK2 EWS is so slow that I can't wait for it.
Comment 13 Simon Fraser (smfr) 2020-04-10 11:18:21 PDT
https://trac.webkit.org/changeset/259883/webkit