Bug 210271 - [GStreamer][MediaStream] Doesn't build with GStreamer 1.10
Summary: [GStreamer][MediaStream] Doesn't build with GStreamer 1.10
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-09 06:47 PDT by Alicia Boya García
Modified: 2020-04-28 07:15 PDT (History)
9 users (show)

See Also:


Attachments
Patch (1.29 KB, patch)
2020-04-28 01:47 PDT, Philippe Normand
calvaris: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2020-04-09 06:47:24 PDT
According to our CMake files, the minimum gst required version for WebRTC is 1.10:

        if (PC_GSTREAMER_VERSION VERSION_LESS "1.10")
            message(FATAL_ERROR "GStreamer 1.10 is needed for ENABLE_MEDIA_STREAM or ENABLE_WEB_RTC")

On the other hand, I built WebKit with 1.10 and found this error.

../../Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.cpp: In member function ‘virtual rtc::scoped_refptr<webrtc::I420BufferInterface> WebCore::GStreamerVideoFrameLibWebRTC::ToI420()’:
../../Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.cpp:126:13: error: ‘GST_VIDEO_CONVERTER_OPT_THREADS’ was not declared in this scope; did you mean ‘GST_VIDEO_CONVERTER_OPT_SRC_X’?

GST_VIDEO_CONVERTER_OPT_THREADS is indeed missing from gst-plugins-base 1.10.5 source code, but is present in 1.12.0.
Comment 1 Philippe Normand 2020-04-28 01:47:15 PDT
Created attachment 397821 [details]
Patch
Comment 2 Philippe Normand 2020-04-28 07:15:26 PDT
Committed r260821: <https://trac.webkit.org/changeset/260821>