Bug 210210 - AX: "Skip to Main Content" navigation broken on US Census site.
Summary: AX: "Skip to Main Content" navigation broken on US Census site.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-08 12:27 PDT by James Craig
Modified: 2020-04-18 00:05 PDT (History)
8 users (show)

See Also:

Attachments
DOM tree screen cap showing bug (71.49 KB, image/png)
2020-04-08 12:27 PDT, James Craig 		no flags Details
patch (6.97 KB, patch)
2020-04-15 22:18 PDT, chris fleizach 		no flags Details | Formatted Diff | Diff
patch (6.97 KB, patch)
2020-04-15 22:19 PDT, chris fleizach 		no flags Details | Formatted Diff | Diff
patch (6.91 KB, patch)
2020-04-18 00:02 PDT, chris fleizach 		no flags Details | Formatted Diff | Diff
patch (6.90 KB, patch)
2020-04-18 00:05 PDT, chris fleizach 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Craig 2020-04-08 12:27:32 PDT 
Created attachment 395853 [details]
DOM tree screen cap showing bug

"Skip to Main Content" navigation broken on US Census site.
https://my2020census.gov

The skip link is nulled (“#”) and then they call a JavaScript function to focus an aria-hidden, yet focusable, empty span.

No surprise this technique doesn’t work (who would do this?) but I think it might be a WebKit bug nonetheless. If focus is moved to a node that is rendered, but hidden via @aria-hidden, WebKit should invalidate the use of aria-hidden on the node or its ancestor node.

ARIA 7.2 Tree Inclusion
https://rawgit.com/w3c/aria/master/#tree_inclusion

"…user agents MUST provide an accessible object in the accessibility tree for DOM elements that…are focusable…"
Comment 1 Radar WebKit Bug Importer 2020-04-08 12:27:52 PDT 
<rdar://problem/61469793>
Comment 2 chris fleizach 2020-04-15 22:18:45 PDT 
Created attachment 396620 [details]
patch
Comment 3 chris fleizach 2020-04-15 22:19:42 PDT 
Created attachment 396621 [details]
patch
Comment 4 Joanmarie Diggs 2020-04-17 09:13:11 PDT 
The change makes sense to me but it looks like some additional tests may be in need of updating/rebasing.
Comment 5 chris fleizach 2020-04-18 00:02:35 PDT 
Created attachment 396837 [details]
patch
Comment 6 chris fleizach 2020-04-18 00:05:19 PDT 
Created attachment 396838 [details]
patch