Bug 210192 - [Wincairo, 32bit] adapt script update-wincairo-libs for 32-bit
Summary: [Wincairo, 32bit] adapt script update-wincairo-libs for 32-bit
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: PC Windows 10
: P2 Normal
Assignee: Nobody
URL:
Keywords: Cairo
Depends on:
Blocks:
 
Reported: 2020-04-08 09:51 PDT by Thomas Brodt
Modified: 2020-07-29 17:00 PDT (History)
2 users (show)

See Also:


Attachments
hacky patch for 32bit WinCairo (3.22 KB, patch)
2020-07-22 14:29 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff
WIP patch (537 bytes, patch)
2020-07-29 17:00 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Brodt 2020-04-08 09:51:45 PDT
the Script update-wincairo-libs updates the required libraries for wincairo if necessary. The script however only downloads the 64 bit zip, although 64 and 32 bit versions of the libraries are built (and I currently still need 32bit, and have changed it to download the 32 bit and it works).

The script should be enhanced with a switch like that

if ('???' == 'x64'):
    file = 'WebKitRequirementsWin64.zip'
else:
    file = 'WebKitRequirementsWin32.zip'

However, I don't know the best test method to decide which dll package should be installed.
Comment 1 Fujii Hironori 2020-07-22 14:29:28 PDT
Created attachment 404964 [details]
hacky patch for 32bit WinCairo

I tested with trunk@264693 and
> perl .\Tools\Scripts\build-webkit --wincairo --release --32-bit
Comment 2 Fujii Hironori 2020-07-29 17:00:16 PDT
Created attachment 405529 [details]
WIP patch

I tested with trunk@265060 and the following command:
> perl .\Tools\Scripts\build-webkit --wincairo --release --32-bit