RESOLVED FIXED 210174
[JSC] Threading JSGlobalObject in RegExp::match properly 
https://bugs.webkit.org/show_bug.cgi?id=210174
Summary [JSC] Threading JSGlobalObject in RegExp::match properly
Yusuke Suzuki
Reported 2020-04-07 23:34:18 PDT
[JSC] Threading JSGlobalObject in RegExp::match properly
Attachments
Patch (24.71 KB, patch)
2020-04-07 23:36 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-04-07 23:36:01 PDT
Created attachment 395773 [details] Patch
Radar WebKit Bug Importer
Comment 2 2020-04-08 00:16:35 PDT
<rdar://problem/61436342>
Saam Barati
Comment 3 2020-04-08 10:40:08 PDT
Comment on attachment 395773 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395773&action=review > Source/JavaScriptCore/runtime/RegExpInlines.h:113 > + if (nullOrGlobalObject) { This is the downside of us using JSCell* everywhere instead of JSCell& When the pointer is actually nullable, we need to name the variable properly
Yusuke Suzuki
Comment 4 2020-04-08 13:01:51 PDT
Committed r259747: <https://trac.webkit.org/changeset/259747>
Note You need to log in before you can comment on or make changes to this bug.