Bug 210174 - [JSC] Threading JSGlobalObject in RegExp::match properly
Summary: [JSC] Threading JSGlobalObject in RegExp::match properly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-07 23:34 PDT by Yusuke Suzuki
Modified: 2020-04-08 13:01 PDT (History)
9 users (show)

See Also:

Attachments
Patch (24.71 KB, patch)
2020-04-07 23:36 PDT, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-04-07 23:34:18 PDT 
[JSC] Threading JSGlobalObject in RegExp::match properly
Comment 1 Yusuke Suzuki 2020-04-07 23:36:01 PDT 
Created attachment 395773 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-04-08 00:16:35 PDT 
<rdar://problem/61436342>
Comment 3 Saam Barati 2020-04-08 10:40:08 PDT 
Comment on attachment 395773 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395773&action=review

> Source/JavaScriptCore/runtime/RegExpInlines.h:113
> +        if (nullOrGlobalObject) {

This is the downside of us using JSCell* everywhere instead of JSCell&

When the pointer is actually nullable, we need to name the variable properly
Comment 4 Yusuke Suzuki 2020-04-08 13:01:51 PDT 
Committed r259747: <https://trac.webkit.org/changeset/259747>