Bug 210163 - [JSC] Collect-continuously thread should take m_collectContinuouslyLock while it is waking up concurrent collector thread
Summary: [JSC] Collect-continuously thread should take m_collectContinuouslyLock while...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-07 15:29 PDT by Yusuke Suzuki
Modified: 2020-04-07 16:25 PDT (History)
7 users (show)

See Also:


Attachments
Patch (6.12 KB, patch)
2020-04-07 15:45 PDT, Yusuke Suzuki
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-04-07 15:29:41 PDT
[JSC] Collect-continuously thread should take m_collectContinuouslyLock while it is waking up concurrent collector thread
Comment 1 Yusuke Suzuki 2020-04-07 15:45:53 PDT
Created attachment 395753 [details]
Patch
Comment 2 Yusuke Suzuki 2020-04-07 15:46:28 PDT
<rdar://problem/61392945>
Comment 3 Saam Barati 2020-04-07 15:52:04 PDT
Comment on attachment 395753 [details]
Patch

r=me
Comment 4 Yusuke Suzuki 2020-04-07 16:09:18 PDT
Comment on attachment 395753 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395753&action=review

> Source/JavaScriptCore/heap/Heap.cpp:2902
>                  while (!m_shouldStopCollectingContinuously) {

I'll put this condition under the lock of m_collectContinuouslyLock
Comment 5 Yusuke Suzuki 2020-04-07 16:25:00 PDT
Committed r259683: <https://trac.webkit.org/changeset/259683>