Bug 210160 – [GTK4] Fix usage of GDK event functions in PlatformWheelEventGtk

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Adrian Perez]

WebCore/platform/gtk/PlatformWheelEventGtk.cpp uses deprecated GDK
functions, we'll need alternative code paths for GTK4 in some cases.

[Adrian Perez]

Created attachment 395747 [details]
Patch

[Michael Catanzaro]

Comment on attachment 395747 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395747&action=review

> Source/WebCore/platform/gtk/PlatformWheelEventGtk.cpp:50
> +#if USE(GTK4)

Wait, are you sure this actually works?

I see you set(GTK_4 TRUE) in FindGTK.cmake, but nothing sets USE_GTK_4.

There's also no way to choose whether you build with GTK 4 or GTK 3 (but I guess that will come later).

[Michael Catanzaro]

Comment on attachment 395747 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395747&action=review

> Source/WebCore/platform/gtk/PlatformWheelEventGtk.cpp:50
> +#if USE(GTK4)

Wait, are you sure this actually works?

I see you set(GTK_4 TRUE) in FindGTK.cmake, but nothing sets USE_GTK_4.

There's also no way to choose whether you build with GTK 4 or GTK 3 (but I guess that will come later).

[Adrian Perez]

(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 395747 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=395747&action=review
> 
> > Source/WebCore/platform/gtk/PlatformWheelEventGtk.cpp:50
> > +#if USE(GTK4)
> 
> Wait, are you sure this actually works?
> 
> I see you set(GTK_4 TRUE) in FindGTK.cmake, but nothing sets USE_GTK_4.
> 
> There's also no way to choose whether you build with GTK 4 or GTK 3 (but I
> guess that will come later).

That would be bug #210154, the patch there needs to be landed first
(note that it a dependency for this bug :D)

[EWS]

Committed r260008: <https://trac.webkit.org/changeset/260008>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395747 [details].