WebCore/platform/gtk/PlatformWheelEventGtk.cpp uses deprecated GDK functions, we'll need alternative code paths for GTK4 in some cases.
Created attachment 395747 [details] Patch
Comment on attachment 395747 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395747&action=review > Source/WebCore/platform/gtk/PlatformWheelEventGtk.cpp:50 > +#if USE(GTK4) Wait, are you sure this actually works? I see you set(GTK_4 TRUE) in FindGTK.cmake, but nothing sets USE_GTK_4. There's also no way to choose whether you build with GTK 4 or GTK 3 (but I guess that will come later).
(In reply to Michael Catanzaro from comment #2) > Comment on attachment 395747 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=395747&action=review > > > Source/WebCore/platform/gtk/PlatformWheelEventGtk.cpp:50 > > +#if USE(GTK4) > > Wait, are you sure this actually works? > > I see you set(GTK_4 TRUE) in FindGTK.cmake, but nothing sets USE_GTK_4. > > There's also no way to choose whether you build with GTK 4 or GTK 3 (but I > guess that will come later). That would be bug #210154, the patch there needs to be landed first (note that it a dependency for this bug :D)
Committed r260008: <https://trac.webkit.org/changeset/260008> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395747 [details].