Bug 210159 - Regression(r259610) [RBSTarget targetWithPid:] may throw a 'must specify a valid pid' exception
Summary: Regression(r259610) [RBSTarget targetWithPid:] may throw a 'must specify a va...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 209990
  Show dependency tree / graph
 
Reported: 2020-04-07 15:05 PDT by Chris Dumez
Modified: 2020-04-08 08:38 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.43 KB, patch)
2020-04-07 15:07 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-04-07 15:05:35 PDT 
[RBSTarget targetWithPid:] may throw a 'must specify a valid pid' exception since r259610. There are apparently cases where the PID we are passing the ProcessAssertion is 0 (likely process crash on startup). BKSAssertion used to deal with this silently but RBSAssertion actually throws an exception in this case. To maintain the old behavior, we should do an explicit check to make sure the PID is valid before passing it to RunningBoard.
Comment 1 Chris Dumez 2020-04-07 15:07:03 PDT 
Created attachment 395743 [details]
Patch
Comment 2 EWS 2020-04-08 08:37:59 PDT 
Committed r259717: <https://trac.webkit.org/changeset/259717>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395743 [details].
Comment 3 Radar WebKit Bug Importer 2020-04-08 08:38:12 PDT 
<rdar://problem/61456395>