Bug 210158 – [GTK4] Make PAL::systemBeep() work

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Adrian Perez]

gdk_beep() is no more in GTK4

[Adrian Perez]

Created attachment 395744 [details]
Patch

[Adrian Perez]

Thanks, I'll land this once the patch for bug #210154 is
in the tree =)

[Michael Catanzaro]

Comment on attachment 395744 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395744&action=review

> Source/WebCore/PAL/pal/system/gtk/SoundGtk.cpp:31
> +    if (auto* display = gdk_display_get_default())
> +        gdk_display_beep(display);

This is available since GDK 2.2. There's no need to use #if here.

[Adrian Perez]

(In reply to Michael Catanzaro from comment #3)
> Comment on attachment 395744 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=395744&action=review
> 
> > Source/WebCore/PAL/pal/system/gtk/SoundGtk.cpp:31
> > +    if (auto* display = gdk_display_get_default())
> > +        gdk_display_beep(display);
> 
> This is available since GDK 2.2. There's no need to use #if here.

Good point, I'll remove the conditional

Note to self: Always check which version first introduced a symbol,
for those cases where we can update the code in ways that it will
work both with GTK3 and GTK4.

[Adrian Perez]

Created attachment 395808 [details]
Patch for lnding

[Adrian Perez]

Committed r259754: <https://trac.webkit.org/changeset/259754>